-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace upstream Dockerfiles with ubi dockerfiles. #362
replace upstream Dockerfiles with ubi dockerfiles. #362
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VedantMahabaleshwarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We also should update the storage initializer one. |
If I am not mistake, custo_transformers and custom_model as well. |
@israel-hdez added the storage initializer dockerfile as well.
@spolti doesn't look like we use/build those today https://github.com/opendatahub-io/kserve/blob/master/config/overlays/odh/params.env |
/retest-required |
4a153d3
to
3c7edd5
Compare
Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
3c7edd5
to
d2c26b7
Compare
@VedantMahabaleshwarkar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@Jooho I checked the CI failures, the failure is not in the test. The |
ci-fast show test passed but full ci failed
ci-slow show test passed but full ci failed
So I think we should ignore the ci failure. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes https://issues.redhat.com/browse/RHOAIENG-6506
Note: Replaced existing Dockerfiles because that file is what Konflux uses to build the images. Also, this will help track any changes to the upstream dockerfile because it will create a merge-conflict (as opposed to maintaining a separate
Dockerfile.ubi8` file).Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
podman build
succeeds locally.