Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace upstream Dockerfiles with ubi dockerfiles. #362

Merged
merged 1 commit into from
May 30, 2024

Conversation

VedantMahabaleshwarkar
Copy link

@VedantMahabaleshwarkar VedantMahabaleshwarkar commented May 21, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://issues.redhat.com/browse/RHOAIENG-6506

Note: Replaced existing Dockerfiles because that file is what Konflux uses to build the images. Also, this will help track any changes to the upstream dockerfile because it will create a merge-conflict (as opposed to maintaining a separate Dockerfile.ubi8` file).

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • tested podman build succeeds locally.

@openshift-ci openshift-ci bot requested review from Jooho and terrytangyuan May 21, 2024 19:55
Copy link

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VedantMahabaleshwarkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
agent.Dockerfile Outdated Show resolved Hide resolved
router.Dockerfile Outdated Show resolved Hide resolved
@israel-hdez
Copy link

We also should update the storage initializer one.

@spolti
Copy link
Member

spolti commented May 22, 2024

We also should update the storage initializer one.

If I am not mistake, custo_transformers and custom_model as well.

@VedantMahabaleshwarkar
Copy link
Author

We also should update the storage initializer one.

@israel-hdez added the storage initializer dockerfile as well.

We also should update the storage initializer one.
If I am not mistake, custo_transformers and custom_model as well.

@spolti doesn't look like we use/build those today https://github.com/opendatahub-io/kserve/blob/master/config/overlays/odh/params.env

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
router.Dockerfile Outdated Show resolved Hide resolved
@VedantMahabaleshwarkar
Copy link
Author

@spolti @Jooho all comments are addressed. PTAL

@VedantMahabaleshwarkar
Copy link
Author

/retest-required

Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
Copy link

openshift-ci bot commented May 30, 2024

@VedantMahabaleshwarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-slow d2c26b7 link true /test e2e-slow
ci/prow/e2e-fast d2c26b7 link true /test e2e-fast

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@VedantMahabaleshwarkar
Copy link
Author

@Jooho I checked the CI failures, the failure is not in the test. The destroy-cluster sub step timed out after the test was successful. The ci failure can be ignored. PTAL.

@Jooho
Copy link

Jooho commented May 30, 2024

ci-fast show test passed but full ci failed

INFO[2024-05-30T18:59:12Z] Running step e2e-fast-e2e-fast.              
WARN[2024-05-30T19:16:52Z] Failed to get namespace ci-op-zvy0gbrz for heartbeating  error=Get "[https://172.30.0.1:443/api/v1/namespaces/ci-op-zvy0gbrz](https://172.30.0.1/api/v1/namespaces/ci-op-zvy0gbrz)": http2: client connection lost
INFO[2024-05-30T19:18:34Z] Step e2e-fast-e2e-fast succeeded after 19m21s. 
INFO[2024-05-30T19:18:34Z] Step phase test succeeded after 19m21s.

ci-slow show test passed but full ci failed

INFO[2024-05-30T19:09:18Z] Step e2e-slow-e2e-slow succeeded after 10m4s. 
INFO[2024-05-30T19:09:18Z] Step phase test succeeded after 10m4s.     

So I think we should ignore the ci failure.

@Jooho Jooho merged commit e717527 into opendatahub-io:master May 30, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants