[pull] master from kserve:master #460
Conversation
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* another squash Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Add JobTTLSecondsAfterFinished option Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Update config Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Use labels to filter jobs instead of deleting old jobs Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Add log in test Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix test and helm chart Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Create a seperate file system utils file Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Add comments Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix status update bug Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> --------- Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
* Allow multiple node groups in the model cache CR Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix test --------- Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
* Clean up jobs Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * fix lint Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix lint Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix deletion propagation policy Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Update test Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> --------- Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
* Add NodeGroup Name Into PVC Name Signed-off-by: Gavin Li <yli1109@bloomberg.net> * Add comment to fix multiple node group Signed-off-by: Dan Sun <dsun20@bloomberg.net> * fix openvino dependency Signed-off-by: Dan Sun <dsun20@bloomberg.net> --------- Signed-off-by: Gavin Li <yli1109@bloomberg.net> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
* Make reconcilation configurable Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix codegen Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Remove a redudant space Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Rename config Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Fix lint Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> --------- Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
… metrics bind port and address in helm chart (#4127) Signed-off-by: Max Howell <maxhowell24@gmail.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
* Fix EOF error Signed-off-by: Jonas Bruns <jonas.bruns@gmx.net> Signed-off-by: jonas <jonas.bruns@gmx.net> * fix error Signed-off-by: Jonas-Bruns <jonas.bruns@gmx.net> Signed-off-by: jonas <jonas.bruns@gmx.net> * rename error to ioErr Signed-off-by: Jonas-Bruns <jonas.bruns@gmx.net> Signed-off-by: jonas <jonas.bruns@gmx.net> * use errors.Is Signed-off-by: Jonas-Bruns <jonas.bruns@gmx.net> Signed-off-by: jonas <jonas.bruns@gmx.net> --------- Signed-off-by: Jonas Bruns <jonas.bruns@gmx.net> Signed-off-by: jonas <jonas.bruns@gmx.net> Signed-off-by: Jonas-Bruns <jonas.bruns@gmx.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pull[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @pull[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* squash commits Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * localmodel agent -> localmodelnode agent Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Revert change Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> --------- Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* Fix model server fails to gracefully shutdown Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update unit tests Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* Add client sdk for localmodelcache, localmodelnodegroup Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Add e2e test for modelcache Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Use docker driver and minikube tunnel Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Merge "Allow multiple node groups in the model cache CR (#4134)" Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Try mounting image dir Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Add local model agent to image scan Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Debug Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Create model root directory beforehand Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Restart kserve controller after patch Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Enablepvc direct mount in e2e test Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Reduce pv storage to 1GB Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update modelcache test Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update status-check to include modelcache logs Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Rajat Vig <rvig@etsy.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* [bugfix] fix s3 storage download filename bug - ensure correct path and file name preservation during s3 downloads in storage-initializer Signed-off-by: Jaeyeon Kim <anencore94@gmail.com> * update lint - fix format Signed-off-by: Jaeyeon Kim <anencore94@gmail.com> * fix format Signed-off-by: Jaeyeon Kim <anencore94@gmail.com> --------- Signed-off-by: Jaeyeon Kim <anencore94@gmail.com>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I think we already did this sync: #459 |
|
@spolti we missed the last commit (kserve#4148) is it ok to sync this commit next time? |
|
it is probably better to do another manual sync, or wait the next automated sync do. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* Add boilerplate setup for embeddings api Signed-off-by: Fabian Scheidt <fabian.scheidt@accenture.com> * Integrate call to model with embedding request Signed-off-by: Fabian Scheidt <fabian.scheidt@accenture.com> * Adjust error responses to be consistent with openai Signed-off-by: Fabian Scheidt <fabian.scheidt@accenture.com> * Adjust doc strings to match implementation Signed-off-by: Fabian Scheidt <fabian.scheidt@accenture.com> * Update openai input validation to use pydantic Signed-off-by: Fabian Scheidt <fabian.scheidt@accenture.com> * Refactor embedding object type Signed-off-by: Fabian Scheidt <fabian.scheidt@accenture.com> * Add e2e test for OpenAI embedding endpoint Signed-off-by: Fabian Scheidt <fabian.scheidt@accenture.com> * Add unit test for OpenAI embeddings Signed-off-by: Fabian Scheidt <fabian.scheidt@accenture.com> --------- Signed-off-by: Fabian Scheidt <fabian.scheidt@accenture.com>
Signed-off-by: Matt Gottlieb <mattgottlieb96@gmail.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )