Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in sed command + Add shell options to scripts #493

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

hdefazio
Copy link

@hdefazio hdefazio commented Feb 11, 2025

What this PR does / why we need it:
Accidentally left out the sed command from #477
Added shell options to the scripts so they would correctly report errors in the CI

Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

Copy link

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hdefazio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdefazio hdefazio marked this pull request as draft February 13, 2025 20:12
@hdefazio
Copy link
Author

hdefazio commented Feb 18, 2025

/rerun-workflow e2e-raw

1 similar comment
@hdefazio
Copy link
Author

/rerun-workflow e2e-raw

@hdefazio hdefazio marked this pull request as ready for review February 19, 2025 14:42
@hdefazio hdefazio changed the title Fix typo in sed command Fix typo in sed command + Add shell options to scripts Feb 19, 2025
Copy link

openshift-ci bot commented Feb 19, 2025

@hdefazio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-fast cb98a79 link true /test e2e-fast
ci/prow/e2e-slow cb98a79 link true /test e2e-slow
ci/prow/e2e-raw cb98a79 link true /test e2e-raw

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@VedantMahabaleshwarkar
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 20, 2025
@hdefazio hdefazio merged commit 4e3f485 into opendatahub-io:master Feb 20, 2025
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants