-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync from upstream master #506
base: master
Are you sure you want to change the base?
Sync from upstream master #506
Conversation
Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> (cherry picked from commit b836fc8)
* squash commits Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * localmodel agent -> localmodelnode agent Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> * Revert change Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> --------- Signed-off-by: Jin Dong <greenmoon55@users.noreply.github.com> (cherry picked from commit cb38637)
* Fix model server fails to gracefully shutdown Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update unit tests Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net> (cherry picked from commit 41a1fd7)
kserve#4152) Ensure root model directory exists and add protection for # of jobs created Signed-off-by: Dan Sun <dsun20@bloomberg.net> (cherry picked from commit 07edb56)
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> (cherry picked from commit 61b0746)
* updated package versions Signed-off-by: ayush <ayush.sawant@nutanix.com> * updated go.mod and pip Signed-off-by: ayush <ayush.sawant@nutanix.com> * updated poetry lock Signed-off-by: ayush <ayush.sawant@nutanix.com> * refactored handling of task argument Signed-off-by: ayush <ayush.sawant@nutanix.com> * removed go.mod changes Signed-off-by: ayush <ayush.sawant@nutanix.com> --------- Signed-off-by: ayush <ayush.sawant@nutanix.com> (cherry picked from commit 5e5bff8)
* Add workflow for verifying go mod Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Merge with go lint workflow Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net> (cherry picked from commit 874a4a4)
upgrade aiohttp Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net> (cherry picked from commit ff13ef8)
* Allow other engine builds other than docker chore: This change will allow user to use other engine builds. In addition, for Podman/Buildah engine builder, users can set the target architecture, useful when using ARM and there is a need to build x86 Container images. Can be done with `ENGINE=podman ARCH="--arch x86_64" make docker...` Signed-off-by: Spolti <fspolti@redhat.com> * review changes Signed-off-by: Spolti <fspolti@redhat.com> --------- Signed-off-by: Spolti <fspolti@redhat.com> (cherry picked from commit 7bec6fb)
Signed-off-by: Jin Dong <jdong183@bloomberg.net> (cherry picked from commit 8f79c44)
* Fixes Non-linear parsing of case-insensitive content chore: Fixes CVE-2024-45338 Non-linear parsing of case-insensitive content in golang.org/x/net/html https://github.com/kserve/kserve/security/dependabot/1871 Signed-off-by: Spolti <fspolti@redhat.com> * update go.sum Signed-off-by: Spolti <fspolti@redhat.com> --------- Signed-off-by: Spolti <fspolti@redhat.com> (cherry picked from commit 5b718bc)
* Helm chart - option to run daemonset as root Signed-off-by: Jin Dong <jdong183@bloomberg.net> * make generate Signed-off-by: Jin Dong <jdong183@bloomberg.net> * Revert default values Signed-off-by: Jin Dong <jdong183@bloomberg.net> * Fix job count test Signed-off-by: Dan Sun <dsun20@bloomberg.net> --------- Signed-off-by: Jin Dong <jdong183@bloomberg.net> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net> (cherry picked from commit 3e842b8)
Replace nodeGroup with nodeGroups Signed-off-by: Rituraj Singh <rsingh660@bloomberg.net> Co-authored-by: Rituraj Singh <rsingh660@bloomberg.net> (cherry picked from commit 7b2681f)
* Add affinity and tolerations to localmodel daemonset Signed-off-by: Jin Dong <jdong183@bloomberg.net> * make generate Signed-off-by: Jin Dong <jdong183@bloomberg.net> --------- Signed-off-by: Jin Dong <jdong183@bloomberg.net> (cherry picked from commit 3597fa7)
…#4157) * sets virtual addressing style for legacy s3 endpoint Signed-off-by: bentohset <toh.benjamin123@gmail.com> * add unit test Signed-off-by: bentohset <toh.benjamin123@gmail.com> * fix formatting Signed-off-by: bentohset <toh.benjamin123@gmail.com> * fix unit tests Signed-off-by: bentohset <toh.benjamin123@gmail.com> --------- Signed-off-by: bentohset <toh.benjamin123@gmail.com> Co-authored-by: Lize Cai <lize.cai@sap.com> (cherry picked from commit cb8a657)
* Make label and annotation propagation configurable chore: Make the DisallaowedAnnotations and Labels configurable through ConfigMap so users can configured it quickly. fixes kserve#3710 Signed-off-by: Spolti <fspolti@redhat.com> * generate boilerplate code Signed-off-by: Spolti <fspolti@redhat.com> * Edgar's review changes Signed-off-by: Spolti <fspolti@redhat.com> --------- Signed-off-by: Spolti <fspolti@redhat.com> (cherry picked from commit 654d314) Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com>
did you break this sync into smaller chunks? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@israel-hdez @Jooho do you want to take a look before merging?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spolti, VedantMahabaleshwarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@spolti Yes, I sent this on slack
|
Vedant confirmed he did e2e test on this PR and passed all except raw. He will follow up the raw e2e test issue so I am ok to merge this PR. |
@VedantMahabaleshwarkar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # https://issues.redhat.com/browse/RHOAIENG-19207
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
unit and e2e tests
Special notes for your reviewer:
Re-running failed tests
/rerun-all
- rerun all failed workflows./rerun-workflow <workflow name>
- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.