Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go version to 1.20 for notebook-controller #330

Merged
merged 1 commit into from
May 23, 2024

Conversation

harshad16
Copy link
Member

Upgrade go version to 1.20 for notebook-controller

Description

Related-to: https://issues.redhat.com/browse/RHOAIENG-7424

How Has This Been Tested?

Tested it with following images:

quay.io/harshad16/odh-kf-notebook-controller-live:go20
quay.io/harshad16/odh-notebook-controller-live:go20

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@atheo89
Copy link
Member

atheo89 commented May 23, 2024

/lgtm

@harshad16
Copy link
Member Author

/approve
Merge it for release

Copy link

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented May 23, 2024

@harshad16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/kf-notebook-controller-pr-image-mirror 1b5cd6b link unknown /test kf-notebook-controller-pr-image-mirror
ci/prow/kf-notebook-controller-unit 1b5cd6b link unknown /test kf-notebook-controller-unit
ci/prow/odh-notebook-controller-pr-image-mirror 1b5cd6b link unknown /test odh-notebook-controller-pr-image-mirror
ci/prow/odh-notebook-controller-unit 1b5cd6b link unknown /test odh-notebook-controller-unit
ci/prow/odh-notebook-controller-e2e 1b5cd6b link unknown /test odh-notebook-controller-e2e
ci/prow/images 1b5cd6b link unknown /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@harshad16 harshad16 merged commit 1bb594d into opendatahub-io:v1.7-branch May 23, 2024
2 of 9 checks passed
@harshad16
Copy link
Member Author

/cherrypick stable

@openshift-cherrypick-robot

@harshad16: new pull request created: #333

In response to this:

/cherrypick stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants