RHOAIENG-16751: chore(gha): add test for checking the values match between Version file and metadata yaml file #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tween Version file and metadata yaml file
|
/lgtm |
andyatmiami
reviewed
Jan 14, 2025
| (cd components/odh-notebook-controller; make manifests generate fmt) | ||
|
|
||
| # component metadata yaml file | ||
| (cd components/notebook-controller; bash generate-metadata-yaml.sh -o config/component_metadata.yaml) |
There was a problem hiding this comment.
the -o argument no longer required... but does no harm
There was a problem hiding this comment.
i'm tempted to remove -o, but since it would then require another lgtm before I can merge, i'm gonna leave it be, thanks
this way it's explicit which file it updates
|
one minor (non-blocking) comment... /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3fbc9c2
into
opendatahub-io:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-16751
Description
Same logic as implemented in
git statuscheck for uncommitted files notebooks#612How Has This Been Tested?
See GHA result below.
Merge criteria: