Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup go-server code #152

Closed
lampajr opened this issue Nov 14, 2023 · 2 comments · Fixed by #155
Closed

Cleanup go-server code #152

lampajr opened this issue Nov 14, 2023 · 2 comments · Fixed by #155
Assignees
@lampajr
Labels
chore Project management or other issues that are not a bug or feature request

Comments

@lampajr
Copy link
Contributor

lampajr commented Nov 14, 2023 •
edited
Loading

As discussed we should cleanup the main branch from old code, i.e., the code related to the go-server implementation of ml-metadata.

To Do:

  1. Create a new branch go-server from actual main.
  2. Cleanup main branch keeping just the proxy server for now and whatever is needed to keep it working

NOTE: thanks to # 1 we do not lose the go-server implementation
@lampajr lampajr added the chore Project management or other issues that are not a bug or feature request label Nov 14, 2023
@lampajr lampajr self-assigned this Nov 14, 2023
@lampajr
Copy link
Contributor Author

lampajr commented Nov 15, 2023 •
edited
Loading

New branch go-server created from main in date Nov 15, 2023 13:24 UTC time: https://github.com/opendatahub-io/model-registry/tree/go-server.

@lampajr lampajr mentioned this issue Nov 15, 2023
Merged
3 tasks
@lampajr
Copy link
Contributor Author

lampajr commented Nov 17, 2023

For the records, this is the squashed commit containing the removal/cleanup: 3e286f3

dhirajsb pushed a commit to dhirajsb/model-registry that referenced this issue Jan 20, 2025
@isinyaaa
Switch Python client backend to use REST (opendatahub-io#152)
9b9be50 
* py: add generated REST backend

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

* py: initial generated code

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

* py: remove gRPC backend

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

* py: rename exceptions

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

* py: wrap generated types

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

* py: core: wrap async client with ctx manager

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

* py: client: wrap async core with sync client

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

* GHA: update python constraints

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

* py: setup mypy

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

---------

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
dhirajsb pushed a commit to dhirajsb/model-registry that referenced this issue Jan 20, 2025
@isinyaaa
Drop logical model mapping tests (opendatahub-io#320)
467e4fb 
* CONTRIBUTING: Get rid of remote-mlmd recommendations

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

* robot: drop logical model mapping tests

Since [1] the Python client doesn't access MLMD directly, instead
routing requests through the MR server, there's no need to check for
matching implementations.

[1]: 9b9be50 "Switch Python client backend to use REST (opendatahub-io#152)"

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>

---------

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lampajr lampajr

Labels
chore Project management or other issues that are not a bug or feature request
Projects
(inactive) ODH Model Registry Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove go-server code from repository
1 participant
@lampajr