Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][grpc] Experiment gRPC gateway #32

Closed
lampajr opened this issue Sep 25, 2023 · 4 comments
Closed

[feature][grpc] Experiment gRPC gateway #32

lampajr opened this issue Sep 25, 2023 · 4 comments
Assignees
Labels

Comments

@lampajr
Copy link
Contributor

lampajr commented Sep 25, 2023

Is your feature request related to a problem? Please describe.
UI can't directly do gRPC requests, therefore we should provide a REST proxy service that can translates REST reqeusts to gRPC ones.

Describe the solution you'd like
One possible solution could be to autogenerate what is called gRPC gateway [1].

Describe alternatives you've considered
None

Additional context
This step should be automated in the build Makefile.

[1] https://grpc-ecosystem.github.io/grpc-gateway/

@lampajr lampajr self-assigned this Sep 25, 2023
@lampajr lampajr changed the title [grpc] Create gRPC gateway [feature][grpc] Create gRPC gateway Sep 25, 2023
@lampajr lampajr changed the title [feature][grpc] Create gRPC gateway [feature][grpc] Experiment gRPC gateway Sep 26, 2023
@lampajr
Copy link
Contributor Author

lampajr commented Sep 27, 2023

Was able to setup a gRPC gateway based on the proto definition following these instructions.

Summaryizing what I did:

  1. Using protoc plugin I automatically generated the proxy server (i.e., the gRPC gateway)
  2. Create a new gateway command aiming to startup the gRPC gateway
  3. Startup a dedicated server which setups a Dial connection with the existing gRPC server
  4. Added a python script that, using REST requests, creates ArtifactType and Artifact instances.

Some considerations:

@rareddy
Copy link
Contributor

rareddy commented Oct 9, 2023

Can we close this as we proved we can do this? We probably need another issue to include this gateway along with the REST API Server #59

@lampajr
Copy link
Contributor Author

lampajr commented Oct 9, 2023

+1 I agree on closing this as the experimentation proved its feasibility.

We probably need another issue to include this gateway along with the REST API Server opendatahub-io/model-registry#59

Not sure this is needed right now as IIUC we do not need to expose the full mlmd gRPC interface as REST

@rareddy
Copy link
Contributor

rareddy commented Oct 9, 2023

Not sure this is needed right now as IIUC we do not need to expose the full mlmd gRPC interface as REST

I heard the envoy-generated gateway is used for training and experimentation, so we may need this enabled. But we could choose to come back to this as an addition over the REST API Model Registry going to support.

dhirajsb pushed a commit to dhirajsb/model-registry that referenced this issue Jan 20, 2025
…sync

periodic sync upstream KF to midstream ODH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants