-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature][grpc] Experiment gRPC gateway #32
Comments
Was able to setup a gRPC gateway based on the proto definition following these instructions. Summaryizing what I did:
Some considerations:
|
Can we close this as we proved we can do this? We probably need another issue to include this gateway along with the REST API Server #59 |
+1 I agree on closing this as the experimentation proved its feasibility.
Not sure this is needed right now as IIUC we do not need to expose the full mlmd gRPC interface as REST |
I heard the envoy-generated gateway is used for training and experimentation, so we may need this enabled. But we could choose to come back to this as an addition over the REST API Model Registry going to support. |
…sync periodic sync upstream KF to midstream ODH
Is your feature request related to a problem? Please describe.
UI can't directly do gRPC requests, therefore we should provide a REST proxy service that can translates REST reqeusts to gRPC ones.
Describe the solution you'd like
One possible solution could be to autogenerate what is called
gRPC gateway
[1].Describe alternatives you've considered
None
Additional context
This step should be automated in the build Makefile.
[1] https://grpc-ecosystem.github.io/grpc-gateway/
The text was updated successfully, but these errors were encountered: