-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from kubeflow:main #121
Conversation
* py: pager: rename limit to page_size ... to improve semantics. Closes: #357 Signed-off-by: Isabella do Amaral <idoamara@redhat.com> * py: fix custom_props typing issue Signed-off-by: Isabella do Amaral <idoamara@redhat.com> * py: test pager descending option Signed-off-by: Isabella do Amaral <idoamara@redhat.com> * py: update README with suggestion Signed-off-by: Isabella do Amaral <idoamara@redhat.com> --------- Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
* Set up model registry context and apiHooks Signed-off-by: lucferbux <lferrnan@redhat.com> * Add selector core loader Signed-off-by: lucferbux <lferrnan@redhat.com> --------- Signed-off-by: lucferbux <lferrnan@redhat.com>
Hi @pull[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
- Coverage 77.55% 77.55% -0.01%
==========================================
Files 17 23 +6
Lines 2090 2094 +4
Branches 143 144 +1
==========================================
+ Hits 1621 1624 +3
Misses 275 275
- Partials 194 195 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- keep Py: rename pager
limit
method topage_size
kubeflow/model-registry#379 - keep Set up model registry context and apiHooks kubeflow/model-registry#360
labels are applied
/lgtm
/approve
🤔 /retest-required |
/test images |
1 similar comment
/test images |
Signed-off-by: Alex Creasy <alex@creasy.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pull[bot], tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pull[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
0cd206f
into
opendatahub-io:main
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )