periodic sync upstream KF to midstream ODH #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... replaces quay.io use in CI/CD/container-registry-use which was available originally through quay.io Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
* py: provide default URI builder for S3 in register_model Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com> * py: provide overloads for type-checking register_model Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com> * py: verify overload signatures at runtime Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com> --------- Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
* add Kustomize 5.2.1 in Kind GHA testing Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> * fix GHA syntax for dependent env Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> * use kustomize install binary instead of dedicated GHA step Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> * kustomize seems installed by default in GHA Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com> --------- Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
...handle gin-generated code by openapi-codegen internally, so to make propert string ptr semantic as expected by core lib, as a query param might not even be passed during requests Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
…o 24.0.9+incompatible (kubeflow#47) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.7+incompatible to 24.0.9+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v24.0.7...v24.0.9) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 76.43% 76.09% -0.35%
==========================================
Files 17 19 +2
Lines 2054 2129 +75
Branches 74 93 +19
==========================================
+ Hits 1570 1620 +50
- Misses 299 319 +20
- Partials 185 190 +5 ☔ View full report in Codecov by Sentry. |
rkubis
approved these changes
Mar 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rkubis, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit dd093b7
into
opendatahub-io:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
content:
with 0ebf88d
register_modelkubeflow/model-registry#39with 0ebf88d