Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for the PyTorch notebooks #187

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Aug 29, 2023

Add test cases for the PyTorch notebooks

Description

This pull request encompasses the addition of test notebooks for both variants of PyTorch notebooks within the 2023a release. The included test notebooks focus on the evaluation of specific Python packages, as follows:

  • torch
  • tensorboard
  • torchvision

This update aims to enhance the testing and validation process for the mentioned PyTorch notebooks, ensuring their compatibility and functionality within the specified package versions

Related: #181

How Has This Been Tested?

Launch the two distinct variants of PyTorch Jupyter Notebook images, 'ubi8' and 'ubi9'. Then, execute the 'test_notebook.ipynb' file in each respective image, and ensure that all tests pass.

To evaluate the PyTorch ubi9:

podman run -it --rm -p 8888:8888  quay.io/opendatahub/workbench-images:jupyter-pytorch-ubi9-python-3.9-pr-187

To evaluate the PyTorch ubi8:

podman run -it --rm -p 8888:8888  quay.io/opendatahub/workbench-images:jupyter-pytorch-ubi8-python-3.8-pr-187

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89 atheo89 force-pushed the testbooks-pytorch branch from 50ae386 to d51513f Compare August 29, 2023 13:11
@atheo89
Copy link
Member Author

atheo89 commented Aug 30, 2023

/retest-required

1 similar comment
@atheo89
Copy link
Member Author

atheo89 commented Aug 30, 2023

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror d51513f link true /test jupyter-datascience-anaconda-python-3-8-pr-image-mirror
ci/prow/images d51513f link true /test images
ci/prow/notebooks-e2e-tests d51513f link true /test notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, rkpattnaik780

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 6, 2023
@harshad16 harshad16 merged commit 5001601 into opendatahub-io:main Sep 6, 2023
@atheo89 atheo89 deleted the testbooks-pytorch branch October 23, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants