Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for minimal notebooks #190

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

rkpattnaik780
Copy link
Contributor

@rkpattnaik780 rkpattnaik780 commented Aug 31, 2023

Add tests for Jupyter minimal notebooks.

Description

This PR adds tests for Datascience notebooks for Python v3.8 and v3.9. The tests check if correct version of python and jupyter exist in the version.

Addresses #180

How Has This Been Tested?

Run Jupyter Minimal Notebooks for both the versions of Python, i.e 3.8 and 3.9. Run the test notebooks in the relevant environment. The tests should execute with all passing.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and harshad16 August 31, 2023 07:39
@openshift-ci openshift-ci bot added the lgtm label Aug 31, 2023
@atheo89 atheo89 removed the lgtm label Aug 31, 2023
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 31, 2023
harshad16

This comment was marked as duplicate.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a doubt:

"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.10.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are on python 3.8 for the notebook.
and the version is 3.10, we can rewrite for 3.8 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this metadata originates from the development environment where the test notebook was initially created. If you copy the content of the notebook run and save it within the corresponding notebook image, I believe this metadata should be resolved.

Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2023

@rkpattnaik780: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/runtime-pytorch-ubi8-python-3-8-pr-image-mirror ecf362c link true /test runtime-pytorch-ubi8-python-3-8-pr-image-mirror
ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror ecf362c link true /test jupyter-datascience-anaconda-python-3-8-pr-image-mirror
ci/prow/images ecf362c link true /test images
ci/prow/notebooks-e2e-tests ecf362c link true /test notebooks-e2e-tests
ci/prow/notebook-jupyter-trustyai-ubi8-python-3-8-pr-image-mirror ecf362c link true /test notebook-jupyter-trustyai-ubi8-python-3-8-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@atheo89
Copy link
Member

atheo89 commented Sep 12, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 12, 2023
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work
/lgtm
/approve

@harshad16 harshad16 merged commit 84cb4c6 into opendatahub-io:main Sep 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants