-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for minimal notebooks #190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a doubt:
"name": "python", | ||
"nbconvert_exporter": "python", | ||
"pygments_lexer": "ipython3", | ||
"version": "3.10.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are on python 3.8 for the notebook.
and the version is 3.10, we can rewrite for 3.8 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this metadata originates from the development environment where the test notebook was initially created. If you copy the content of the notebook run and save it within the corresponding notebook image, I believe this metadata should be resolved.
Signed-off-by: rkpattnaik780 <rkpattnaik780@gmail.com>
deab9ff
to
ecf362c
Compare
@rkpattnaik780: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add tests for Jupyter minimal notebooks.
Description
This PR adds tests for Datascience notebooks for Python v3.8 and v3.9. The tests check if correct version of python and jupyter exist in the version.
Addresses #180
How Has This Been Tested?
Run Jupyter Minimal Notebooks for both the versions of Python, i.e 3.8 and 3.9. Run the test notebooks in the relevant environment. The tests should execute with all passing.
Merge criteria: