Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RHEL9 repository for UBI9 and CentOs Stream 9 Cuda images #200

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Sep 1, 2023

This updates the used Nvidia repository for CUDA packages in our UBI9 and CoreOs 9 Stream images.

Description

Nvidia provides RHEL9 repository of their packages. We use RHEL8 for all of our images at the moment (UBI8, UBI9, CoreOs 9 Stream). I think we should use RHEL9 repository for UBI9 and CoreOS 9 Stream, since I believe these are closer to the RHEL9.

I haven't checked content and difference of the Nvidia rhel8 vs rhel9 repositories yet, I can do it if you ask. It's possible that most of the packages there will be identical, not sure how they build.

Please, let me know whether this change is welcomed actually. Thank you.

How Has This Been Tested?

!!!! This hasn't been tested and since this is quite a big change we should definitely test before we merge this !!!!

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from dibryant and harshad16 September 1, 2023 20:52
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2023

Hi @jstourac. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atheo89
Copy link
Member

atheo89 commented Sep 4, 2023

/ok-to-test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2023

@jstourac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror ea74881 link true /test jupyter-datascience-anaconda-python-3-8-pr-image-mirror
ci/prow/notebooks-e2e-tests ea74881 link true /test notebooks-e2e-tests
ci/prow/images ea74881 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Good catch
Thanks 💯

@openshift-ci openshift-ci bot added the lgtm label Sep 6, 2023
@harshad16 harshad16 merged commit 19482f3 into opendatahub-io:main Sep 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 6, 2023
@jstourac jstourac deleted the rhel9CudaRepos branch September 6, 2023 13:44
harshad16 added a commit to harshad16/odh-notebooks that referenced this pull request Apr 6, 2024
Remove the intel based image from the overlay as its ODH only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants