Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the pytorch image reference to commit 88211f5 #247

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

harshad16
Copy link
Member

Fix the pytorch image reference to commit 88211f5

Description

The reference of pytorch was pointing to base-c9s image.
This fixes it and point it to reference: https://quay.io/repository/opendatahub/workbench-images/manifest/sha256:6a8027f47dd3a21fc10cc4826f9632c330cb71d9933c2bcb93cbe7180f468758

Fixes: #246

How Has This Been Tested?

Execute the following

podman run -p 8888:8888 quay.io/opendatahub/workbench-images@sha256:6a8027f47dd3a21fc10cc4826f9632c330cb71d9933c2bcb93cbe7180f468758

or

make deploy9-jupyter-pytorch-ubi9-python-3.9 -e IMAGE_REGISTRY="quay.io/opendatahub/workbench-images" -e NOTEBOOK_TAG=jupyter-pytorch-ubi9-python-3.9-2023a-20230918-88211f5
make test-jupyter-pytorch-ubi9-python-3.9
make undeploy9-jupyter-pytorch-ubi9-python-3.9

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@openshift-ci openshift-ci bot requested review from atheo89 and dibryant October 9, 2023 12:46
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 9, 2023
@openshift-ci openshift-ci bot merged commit b50dc1d into opendatahub-io:1.10.x Oct 9, 2023
@harshad16 harshad16 deleted the fix-pytorch-image branch October 20, 2023 18:25
harshad16 added a commit to harshad16/odh-notebooks that referenced this pull request May 27, 2024
…st-updater-9213110410

[Digest Updater Action] Update Runtime Images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants