-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-install minimal requirment python packages on vscode #374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Able to run code snippets that use the added libraries.
/approve
I was just talking about this, Python packages in VSCode, to a colleague of mine this week. So nice to see this! Looking good at first glance. Also, we have a topic of where to put VSCode extensions and make them available without download ... but that is a different story. Best regards from snowy CH. |
Glad to hear that! 🙂
We are cooking something as well for this! Check out here: #347
Greetings from Turin on the other side of the Alps! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the excellent work.
After closing checking, feels like we are install more packages then intended
codeserver/ubi9-python-3.9/Pipfile
Outdated
|
||
# PyTorch packages | ||
tensorboard = "~=2.15.1" | ||
torch = {version = "~=2.1.1", index = "pytorch"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for only installing torch and not tensorflow.
on hindsight , i feel we should not install any of these big packages.
and only stick with basic packages like
boto3, matplotlib, pandas, numpy, scipy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, there is a similar issue in @guimou recent changes to the contrib datascience UI python packages, they have all sorts of heavy nvidia* libraries in it, regardless of whether the base docker image is for Tensorflow or not. opendatahub-io-contrib/workbench-images#48. Agreed that in a first step here, minimal might be good. And you could get these changes here in this PR into the snippets for codeserver VSCode at contrib, so users can then always add more of their own packages, if they want to, in own builds. Or maybe I could suggest that as a PR there ... how much are you in contact with Guillome? Having this in the image build framework he introduced would enable end users to build their custom offline / airgapped images with as many python libraries as they want. That applies to the VSCode extensions topic, too. The groundwork @atheo89 has done is great in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing this! 😊 I was in a dilemma about whether to include the most advanced packages or not. I agree with you; I'll omit them for now and stick to the basic data science packages.
Yeah, the issue comes from the codeflare sdk, which has dependencies on
pytorch, then nvidia...
For contrib I wanted to introduce codeflare in all the images, as well as
Elyra/kfp-tekton, but I'm not sure it's a good idea.
I talked to the Codeflare team, they were supposed to review their
dependencies, I did not check yet if they managed to have less heavy
dependencies.
So I guess it will come down to another discussion: which images should
include Codeflare sdk?
…On Wed., Dec. 6, 2023, 01:34 Sven Thoms, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In codeserver/ubi9-python-3.9/Pipfile
<#374 (comment)>
:
> +kafka-python = "~=2.0.2"
+matplotlib = "~=3.8.2"
+numpy = "~=1.26.2"
+pandas = "~=2.1.3"
+plotly = "~=5.18.0"
+scikit-learn = "~=1.3.2"
+scipy = "~=1.11.4"
+skl2onnx = "~=1.15.0"
+codeflare-sdk = "~=0.12.1"
+kfp = "~=1.8.22"
+kfp-tekton = "~=1.8.1"
+ipykernel = "~=6.26.0"
+
+# PyTorch packages
+tensorboard = "~=2.15.1"
+torch = {version = "~=2.1.1", index = "pytorch"}
yes, there is a similar issue in @guimou <https://github.com/guimou>
recent changes to the contrib datascience UI pathon packages, they have all
sorts of heavy nvidia* libraries in it, regardless of whether the base
docker image is for Tensorflow or not.
opendatahub-io-contrib/workbench-images#48
<opendatahub-io-contrib/workbench-images#48>.
Agreed that in a first step here, minimal might be good. And you could get
these changes here in this PR into the snippets for codeserver VSCode at
contrib
<https://github.com/opendatahub-io-contrib/workbench-images/tree/main>,
so users can then always add more of their own packages, if they want to,
in own builds.
—
Reply to this email directly, view it on GitHub
<#374 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6C4YU52S62XYWUM7M3I3DYIAGXNAVCNFSM6AAAAAA75LDPHWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONRWG42DSNZZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@guimou codeflare, I see. To keep that aspect separate for the other contrib images context, I answered in odh-contrib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work, lgtm.
/lgtm
/approve
Thanks all
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16, rkpattnaik780 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to: #345
Description
This PR introduce a minimal list of python packages that are required for data sciences and programming workloads.
NOTE: Will follow up a separated issue/pr to incorporate the standard database clients #372
How Has This Been Tested?
pip list
and ensure there is a long list with packagesYou shall see the following plot:
In case of issue check which interpreter you are using
Merge criteria: