Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Update runtime image on main based on the commit id: 2c69d58 #399

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

harshad16
Copy link
Member

Upgrade: Update runtime image on main based on the commit id: 2c69d58

Description

Upgrade: Update runtime image on main based on the commit id: 2c69d58
As code-flare version change, updating the runtime images as well.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@openshift-ci openshift-ci bot requested review from atheo89 and dibryant February 2, 2024 19:35
Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16
Copy link
Member Author

Merging this, it is reqiured for feature freeze 2.7

@harshad16 harshad16 merged commit 0abd40b into opendatahub-io:main Feb 2, 2024
1 of 14 checks passed
@harshad16
Copy link
Member Author

/cherrypick 2023b

@openshift-cherrypick-robot

@harshad16: new pull request created: #400

In response to this:

/cherrypick 2023b

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shalberd
Copy link
Contributor

shalberd commented Feb 5, 2024

Hi @harshad16 is there a way for the tags, as they appear in Elyra GUI, to also refer to the tag from quay.io behind the digest, i.e. runtime-pytorch-ubi8-python-3.8-2023b-20240202-2c69d58? More than just datascience in the tags array, I mean.

That way, users could infer back the actual tag in quay.io from the digest.

dibryant pushed a commit to dibryant/notebooks that referenced this pull request Oct 11, 2024
…ndatahub-io#399)

* Fix the digest updater GHA regexp array initialization

After the removal of the habana image from the set of regexps in
red-hat-data-services#384, there was kept a wrong syntax
causing this part of the GHA to fail. This change fixes this.

* Fix the regexps for the digest updater for 2024b images releases

The regexps updated was missed as part of the red-hat-data-services#383
as there was nothing to test the GHA with before it got merged. This change
should fix it making the update for the 2024b working from now on.

* Update the notebook digest update GHA name and description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants