Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gh-actions] Make yamllint strict and other changes #432

Merged
merged 1 commit into from
Feb 26, 2024
Merged

[gh-actions] Make yamllint strict and other changes #432

merged 1 commit into from
Feb 26, 2024

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Feb 25, 2024 •
edited
Loading

  • Let's make yamllint strict
  • Get rid of the yamllint GH action that may be out of date eventually
  • Code linter warning fix into sec-scan.yml
  • Update actions/checkout GH action to latest version

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jstourac jstourac self-assigned this Feb 25, 2024
@jstourac jstourac changed the title [gh-actions] Make yamllint strict [gh-actions] Make yamllint strict and other changes Feb 25, 2024
@jstourac jstourac marked this pull request as ready for review February 25, 2024 14:24
@openshift-ci openshift-ci bot requested review from dibryant and harshad16 February 25, 2024 14:24
@atheo89
Copy link
Member

atheo89 commented Feb 26, 2024

Thanks Jan, the changes /lgtm

@atheo89 atheo89 added the lgtm label Feb 26, 2024
rkpattnaik780
rkpattnaik780 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@rkpattnaik780 rkpattnaik780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

jiridanek
jiridanek approved these changes Feb 26, 2024
View reviewed changes
.github/workflows/code-quality.yaml Outdated
@@ -9,25 +9,26 @@ jobs:
code-static-analysis:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep it @v4 and let it auto update

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, wasn't aware - https://github.com/orgs/community/discussions/48058 . Thanks, I'll update.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

@jiridanek: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jstourac
[gh-actions] Make yamllint strict and other changes
5a4f299 
* Let's make yamllint strict
* Get rid of the yamllint GH action that may be out of date eventually
* Code linter warning fix into `sec-scan.yml`
* Update actions/checkout GH action to latest version
@openshift-ci openshift-ci bot removed the lgtm label Feb 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

@jiridanek: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

harshad16
harshad16 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

👍

@openshift-ci openshift-ci bot added the lgtm label Feb 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek, rkpattnaik780

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5ddab06 into opendatahub-io:main Feb 26, 2024
3 checks passed
@jstourac jstourac deleted the actions branch February 27, 2024 06:25
jstourac pushed a commit to jstourac/notebooks that referenced this pull request Nov 13, 2024
@atheo89
Merge pull request opendatahub-io#432 from red-hat-data-services/dige…
96c8e2c 
…st-updater-11784213160

[Digest Updater Action] Update Notebook Images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkpattnaik780 rkpattnaik780 rkpattnaik780 approved these changes

@harshad16 harshad16 harshad16 approved these changes

@jiridanek jiridanek jiridanek approved these changes

@dibryant dibryant Awaiting requested review from dibryant

@atheo89 atheo89 Awaiting requested review from atheo89

Assignees

@jstourac jstourac

@harshad16 harshad16

@rkpattnaik780 rkpattnaik780

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jstourac @atheo89 @jiridanek @harshad16 @rkpattnaik780