Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH actions to use Node20 #463

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

jstourac
Copy link
Member

Following warning can be seen in the GH Actions runs:

Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20: <action name>. For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Note - this project doesn't provide any update for this migration yet: https://github.com/actions/add-to-project/releases

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Following warning can be seen in the GH Actions runs:

```
Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20: <action name>. For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
```

Note - this project doesn't provide any update for this migration yet:
https://github.com/actions/add-to-project/releases
@openshift-ci openshift-ci bot requested review from dibryant and harshad16 March 16, 2024 20:15
Copy link
Contributor

openshift-ci bot commented Mar 16, 2024

@jstourac: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images ebe0585 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@atheo89
Copy link
Member

atheo89 commented Mar 18, 2024

Thank you Jan! 🙂
/lgtm

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

@harshad16 harshad16 merged commit 0a56535 into opendatahub-io:main Mar 19, 2024
0 of 3 checks passed
Copy link
Contributor

openshift-ci bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstourac jstourac deleted the updateActions branch March 19, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants