Remove kfp_tekton from the testing notebooks

[atheo89]

Related to: https://issues.redhat.com/browse/RHOAIENG-4784

Description

The end-to-end tests in the notebooks repository are failing because the kfp_tekton library has been removed and replaced with odh-elyra.

Ref on CI test: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/opendatahub-io_notebooks/476/pull-ci-opendatahub-io-notebooks-main-notebooks-e2e-tests/1771201766046568448#1:build-log.txt%3A518

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[jstourac]

For reference - kfp-tekton removal in #467

[jstourac]

Do we want to remove it also from the intel one? I still can see the kfp-tekton in relevant Pipfile here?

Actually, writing this comment now, is it okay that some of our images under the jupyter directory still contains the kfp-tekton?

$ grep -r kfp-tekton                                                                         
jupyter/intel/pytorch/ubi9-python-3.9/Pipfile.cpu:kfp-tekton = "<1.6.0"
jupyter/intel/pytorch/ubi9-python-3.9/Pipfile.gpu:kfp-tekton = "<1.6.0"
jupyter/intel/pytorch/ubi9-python-3.9/Pipfile.lock.cpu:        "kfp-tekton": {
jupyter/intel/pytorch/ubi9-python-3.9/Pipfile.lock.gpu:        "kfp-tekton": {
jupyter/intel/ml/ubi9-python-3.9/Pipfile:kfp-tekton = "<1.6.0"
jupyter/intel/ml/ubi9-python-3.9/Pipfile.lock:        "kfp-tekton": {
jupyter/intel/tensorflow/ubi9-python-3.9/Pipfile.cpu:kfp-tekton = "<1.6.0"
jupyter/intel/tensorflow/ubi9-python-3.9/Pipfile.gpu:kfp-tekton = "<1.6.0"
jupyter/intel/tensorflow/ubi9-python-3.9/Pipfile.lock.cpu:        "kfp-tekton": {
jupyter/intel/tensorflow/ubi9-python-3.9/Pipfile.lock.gpu:        "kfp-tekton": {
habana/1.10.0/ubi8-python-3.8/Pipfile:kfp-tekton = "<1.6.0"
habana/1.10.0/ubi8-python-3.8/Pipfile.lock:        "kfp-tekton": {
habana/1.11.0/ubi8-python-3.8/Pipfile:kfp-tekton = "<1.6.0"
habana/1.11.0/ubi8-python-3.8/Pipfile.lock:        "kfp-tekton": {
habana/1.9.0/ubi8-python-3.8/Pipfile:kfp-tekton = "<1.6.0"
habana/1.9.0/ubi8-python-3.8/Pipfile.lock:        "kfp-tekton": {
habana/1.13.0/ubi8-python-3.8/Pipfile:kfp-tekton = "<1.6.0"
habana/1.13.0/ubi8-python-3.8/Pipfile.lock:        "kfp-tekton": {

If this is something we need for the DSPv2, shouldn't we update this for all supported images? Maybe we don't care about the intel ones for rhoai and we care just about the habana 1.13?

[atheo89]

Hey, Jan thanks for the review! 🙂
I'll revert the change from Intel since this PR was already in place before the removal of kfp_tekton.

Regarding Habana - The latest 1.13 has been updated with the removal [1] but the others haven't.
@harshad16 what are your thoughts on what we should do for the rest of Habana?

[jstourac]

Ah, yeah, sorry about it - forgot to update the local cloned repo 🙃 this is good then.

Regarding the others - let's see what Harshad thinks. Technically, we should care just about the "supported" (not sure what we mean with it in upstream, though) images so they can work with the DSPv2, correct?

[harshad16]

No changes are required for the intel-based images.
we would work on the intel-based images, as we move further in upcoming sprints.

[harshad16]

/lgtm
/approve

thanks 💯

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [harshad16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[harshad16]

/test notebooks-e2e-tests

[openshift-ci]

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/habana-notebooks-e2e-tests	9bdcdd2	link	true	/test habana-notebooks-e2e-tests
ci/prow/images	9bdcdd2	link	true	/test images
ci/prow/notebooks-e2e-tests	9bdcdd2	link	true	/test notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.