Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the Intel based ML, PyTorch, TensorFlow Images to Workbenches… #480

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

harshad16
Copy link
Member

@harshad16 harshad16 commented Mar 28, 2024

Include the Intel based ML, PyTorch, TensorFlow Images to Workbenches manifests

Description

https://issues.redhat.com/browse/RHOAIENG-3777

Required for ODH 2.10.

How Has This Been Tested?

The Testing of this would be async.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

… manifests

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@openshift-ci openshift-ci bot requested review from atheo89 and rkpattnaik780 March 28, 2024 06:14
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@harshad16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebooks-e2e-tests a2f9769 link true /test notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@harshad16
Copy link
Member Author

Thank you for the review.

@harshad16 harshad16 merged commit c852d47 into opendatahub-io:main Mar 29, 2024
2 of 4 checks passed
jiridanek pushed a commit to jiridanek/notebooks that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants