Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expected values for the Habana 2024a and 2023b images in CI #523

Merged
merged 1 commit into from
May 13, 2024

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented May 9, 2024

Description

Update expected values for the Habana 2024a and 2023b images in CI.

https://issues.redhat.com/browse/RHOAIENG-7884

How Has This Been Tested?

Run ./ci/check-params-env.sh

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and rkpattnaik780 May 9, 2024 18:54
@jstourac
Copy link
Member Author

jstourac commented May 9, 2024

One thing - I haven't go deep into when we should expect the -amd64 suffix in the openshift build name. If any of you know, please let me know, otherwise I'll dig into it.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks for the work 💯

@openshift-ci openshift-ci bot removed the lgtm label May 12, 2024
@jstourac jstourac changed the title Update expected values for the Habana 2024a image in CI Update expected values for the Habana 2024a and 2023b images in CI May 12, 2024
@jstourac
Copy link
Member Author

Rebased and updated based on the latest changes in the images - looks like we don't have any exception in the checked values anymore, good job 🙂

@atheo89
Copy link
Member

atheo89 commented May 13, 2024

Override the tests, because the #521 is still in progress.
/override ci/prow/images
/override ci/prow/notebooks-e2e-tests

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented May 13, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebooks-e2e-tests

In response to this:

Override the tests, because the #521 is still in progress.
/override ci/prow/images
/override ci/prow/notebooks-e2e-tests

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 661caea into opendatahub-io:main May 13, 2024
4 checks passed
@jstourac jstourac deleted the fixCiHabanaImg branch May 13, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants