Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: get a list of changed files using git diff instead of GitHub APIv4 #602

Merged

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jun 28, 2024

This approach is significantly slower than using the GitHub API (3s instead of 1s), but it is less magical for those unfamiliar with the API. So there are reasons to prefer this slower approach.

Description

Fixes #560

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jiridanek jiridanek force-pushed the jd_use_git_not_gh_api branch from ceb5c34 to 9a9a4a0 Compare June 29, 2024 07:18
@jiridanek jiridanek marked this pull request as ready for review June 29, 2024 07:19
@openshift-ci openshift-ci bot requested a review from dibryant June 29, 2024 07:19
Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: caponetto, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ab84dfa into opendatahub-io:main Jul 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe get a list of changed files using git diff and pass them to the script?
4 participants