RHOAIENG-11087 Fix: Remove install of package in bootstrapper as pre-installed #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jstourac
reviewed
Aug 8, 2024
…installed Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
harshad16
force-pushed
the
remove-install-package
branch
from
53d057a to
d30b6e6
Compare
|
/lgtm |
|
/lgtm |
|
Thanks for the PR review |
3 tasks
caponetto
added a commit
to caponetto/opendatahub-io-notebooks
that referenced
this pull request
Aug 8, 2024
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
* Add images based on python 3.11 * Apply #656 to Python 3.11 images * Fix expected TF vesion on the test file * Fix labels for Python 3.11 * Apply #652 to Python 3.11 images * Update lock to fix debugpy package version * Apply #635 to Python 3.11 images * Replace 3-9 -> 3-11 leftovers * Fix runtime rocm image name according to openshift/release * Apply #667 to Python 3.11 images * Adapt test code for Python 3.11 images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Remove install of package in bootstrapper as pre-installed
Description
Related-to: https://issues.redhat.com/browse/RHOAIENG-11087
These changes were added back bsaed on this: #579
causing the regression.
As we pre-install packages in the images, with this feature: #330
we no longer require change to be updated during the runtime.
How Has This Been Tested?
Tested with: #330
Execute the pipeline using the notebook provide by this PR
and see that the packages are already present
Merge criteria: