-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-16076: tests(gha): install a cri-o backed kubernetes for running Makefile tests #783
RHOAIENG-16076: tests(gha): install a cri-o backed kubernetes for running Makefile tests #783
Conversation
Skipping CI for Draft Pull Request. |
452a664
to
fc9ad2c
Compare
/override ci/prow/images |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I put couple of comments - either not important and maybe even irrelevant. Otherwise this LGTM. Very nice exploration, Jiri! |
Co-authored-by: Jan Stourac <jstourac@redhat.com>
All my comments answered/addressed. Thank you! /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/images |
I'm going to merge it now. In case any one else wants to leave review comments, I'll be happy to address in subsequent fixup pr if any fixes are suggested. Now onto the final step of actually running the tests! |
@jiridanek: jiridanek unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Another bot is rebelling? /override ci/prow/images |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
That's better |
117a479
into
opendatahub-io:main
…ning Makefile tests (opendatahub-io#783) * RHOAIENG-16076: tests(gha): install a cri-o backed kubernetes for running tests * Update .github/workflows/build-notebooks-TEMPLATE.yaml Co-authored-by: Jan Stourac <jstourac@redhat.com> --------- Co-authored-by: Jan Stourac <jstourac@redhat.com> (cherry picked from commit 117a479)
…ning Makefile tests (opendatahub-io#783) * RHOAIENG-16076: tests(gha): install a cri-o backed kubernetes for running tests * Update .github/workflows/build-notebooks-TEMPLATE.yaml Co-authored-by: Jan Stourac <jstourac@redhat.com> --------- Co-authored-by: Jan Stourac <jstourac@redhat.com> (cherry picked from commit 117a479)
https://issues.redhat.com/browse/RHOAIENG-16076
Another chunk of the
changes to be reviewed and merged.
Description
Installs CRI-O (https://cri-o.io/) and deploys a cluster with
kubeadm init
. In the final PR, this infrastructure will be used to run our Makefile tests, as a final step of this series of PRs.Depends on
containers/storage
with cri-o later #782to be in place. So a rebase is likely needed when the above PR is merged.
How Has This Been Tested?
Merge criteria: