Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-16076: tests(gha): install a cri-o backed kubernetes for running Makefile tests #783

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Nov 26, 2024

https://issues.redhat.com/browse/RHOAIENG-16076

Another chunk of the

changes to be reviewed and merged.

Description

Installs CRI-O (https://cri-o.io/) and deploys a cluster with kubeadm init. In the final PR, this infrastructure will be used to run our Makefile tests, as a final step of this series of PRs.

Depends on

to be in place. So a rebase is likely needed when the above PR is merged.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jiridanek jiridanek changed the title Jd notebooks gha make/installkube RHOAIENG-16076: tests(gha): install a cri-o backed kubernetes for running Makefile tests Nov 26, 2024
@jiridanek jiridanek force-pushed the jd_notebooks_gha_make/installkube branch from 452a664 to fc9ad2c Compare November 26, 2024 10:09
@jiridanek jiridanek added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 26, 2024
@jiridanek jiridanek marked this pull request as ready for review November 26, 2024 10:18
@jiridanek jiridanek requested review from jstourac and daniellutz and removed request for daniellutz and dibryant November 26, 2024 10:18
@jiridanek
Copy link
Member Author

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstourac
Copy link
Member

I put couple of comments - either not important and maybe even irrelevant. Otherwise this LGTM. Very nice exploration, Jiri!

Co-authored-by: Jan Stourac <jstourac@redhat.com>
@jstourac
Copy link
Member

All my comments answered/addressed. Thank you!

/lgtm

@jiridanek
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member Author

/override ci/prow/images

@jiridanek
Copy link
Member Author

jiridanek commented Nov 28, 2024

I'm going to merge it now. In case any one else wants to leave review comments, I'll be happy to address in subsequent fixup pr if any fixes are suggested.

Now onto the final step of actually running the tests!

Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

@jiridanek: jiridanek unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

Another bot is rebelling?

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

Another bot is rebelling?

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

That's better

@openshift-merge-bot openshift-merge-bot bot merged commit 117a479 into opendatahub-io:main Nov 28, 2024
12 checks passed
jiridanek added a commit to jiridanek/notebooks that referenced this pull request Dec 18, 2024
…ning Makefile tests (opendatahub-io#783)

* RHOAIENG-16076: tests(gha): install a cri-o backed kubernetes for running tests

* Update .github/workflows/build-notebooks-TEMPLATE.yaml

Co-authored-by: Jan Stourac <jstourac@redhat.com>

---------

Co-authored-by: Jan Stourac <jstourac@redhat.com>
(cherry picked from commit 117a479)
jiridanek added a commit to jiridanek/notebooks that referenced this pull request Dec 19, 2024
…ning Makefile tests (opendatahub-io#783)

* RHOAIENG-16076: tests(gha): install a cri-o backed kubernetes for running tests

* Update .github/workflows/build-notebooks-TEMPLATE.yaml

Co-authored-by: Jan Stourac <jstourac@redhat.com>

---------

Co-authored-by: Jan Stourac <jstourac@redhat.com>
(cherry picked from commit 117a479)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants