Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Piplock Renewal GitHub Action #805

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Dec 11, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-15393

Description

This PR consolidates multiple changes related to Pipfile.lock files generation. The main goal is to streamline the process of updating Pipfile.lock files across

The following updates have been made:

  • Refined the piplock-renewal.yaml GitHub Action to facilitate automated updates and automerging of Pipfile.lock files, with user-configurable Python versions, branch and optional directory updates.
  • Modified the refresh-pipfilelock-files makefile to support updates for optional directories.
  • Included the codeserver notebook in the refresh recipe.
  • Improved compatibility for the Intel flavor of the makefile as they are not official supported
  • Removed .github/workflows/piplock-renewal-YYYYx.yml as we will not use them anymore
    - Add .gitignore files to block user push pipfile.lock, as from now on will be populated only by piplock-renewal.yaml action.
  • Update the Readme.md and CONTRIBUTING.md files

How Has This Been Tested?

The functionality of these updates tested locally:
DIRS for testing purposes https://github.com/atheo89/notebooks/blob/main/Makefile#L643

Having optional dirs = false
https://github.com/atheo89/notebooks/actions/runs/12274941817/job/34248935523

Having optional dirs = true
https://github.com/atheo89/notebooks/actions/runs/12275077390/job/34249373408

workflow_dispatch inputs from the user, none of them is required:
image

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@atheo89 atheo89 force-pushed the RHOAIENG-15393 branch 4 times, most recently from 74270d4 to 8f50674 Compare December 12, 2024 09:46
Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tab formatting is difficult. I remember we were struggling with it every time Makefile had to be updated. We should seriously consider

@atheo89 atheo89 force-pushed the RHOAIENG-15393 branch 2 times, most recently from 9c56a9e to a3b71de Compare December 12, 2024 12:32
@atheo89
Copy link
Member Author

atheo89 commented Dec 12, 2024

I removed the .gitignore from the subfolders and i added on top level as Jiri proposed.

The tab formatting is difficult. I remember we were struggling with it every time Makefile had to be updated. We should seriously consider
NO-JIRA: chore(Makefile): replace ^\t (that's the default .RECIPEPREFIX) with > #806

That's cool, I will rebase and apply the same, as soon your PR get merged

Remove old obsolete files

Include codeserver notebook on the refresh-piplock-files recipe

Update refresh-pipfilelock-files to accept optional file directories for updates

Update documentation in regards the Pipfile lock generation
@jiridanek
Copy link
Member

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror 74270d4 link true /test notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror 74270d4 link true /test notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror
ci/prow/runtime-rocm-tensorflow-ubi9-python-3-11-pr-image-mirror 74270d4 link true /test runtime-rocm-tensorflow-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-rocm-ubi9-python-3-11-pr-image-mirror 8f50674 link true /test notebook-rocm-ubi9-python-3-11-pr-image-mirror
ci/prow/runtime-pytorch-ubi9-python-3-11-pr-image-mirror 8f50674 link true /test runtime-pytorch-ubi9-python-3-11-pr-image-mirror
ci/prow/runtime-pytorch-ubi9-python-3-9-pr-image-mirror 8f50674 link true /test runtime-pytorch-ubi9-python-3-9-pr-image-mirror
ci/prow/runtime-intel-pyt-ubi9-python-3-9-pr-image-mirror 8f50674 link true /test runtime-intel-pyt-ubi9-python-3-9-pr-image-mirror
ci/prow/runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror 8f50674 link true /test runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror
ci/prow/notebooks-ubi9-e2e-tests 8f50674 link true /test notebooks-ubi9-e2e-tests
ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror 8f50674 link true /test runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-rocm-jupyter-min-ubi9-python-3-11-pr-image-mirror 8f50674 link true /test notebook-rocm-jupyter-min-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror 8f50674 link true /test notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jstourac
Copy link
Member

Thank you for amending this Adriana! Let's get these changes in.

/lgtm

@atheo89
Copy link
Member Author

atheo89 commented Dec 13, 2024

Thank you for your review guys.
/approve

Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member Author

atheo89 commented Dec 13, 2024

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants