-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Piplock Renewal GitHub Action #805
Update Piplock Renewal GitHub Action #805
Conversation
74270d4
to
8f50674
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tab formatting is difficult. I remember we were struggling with it every time Makefile had to be updated. We should seriously consider
9c56a9e
to
a3b71de
Compare
I removed the
That's cool, I will rebase and apply the same, as soon your PR get merged |
a3b71de
to
9ac2fa3
Compare
Remove old obsolete files Include codeserver notebook on the refresh-piplock-files recipe Update refresh-pipfilelock-files to accept optional file directories for updates Update documentation in regards the Pipfile lock generation
9ac2fa3
to
ca80fee
Compare
/lgtm |
@atheo89: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Thank you for amending this Adriana! Let's get these changes in. /lgtm |
Thank you for your review guys. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/images |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Related to: https://issues.redhat.com/browse/RHOAIENG-15393
Description
This PR consolidates multiple changes related to Pipfile.lock files generation. The main goal is to streamline the process of updating Pipfile.lock files across
The following updates have been made:
piplock-renewal.yaml
GitHub Action to facilitate automated updates and automerging of Pipfile.lock files, withuser-configurable
Python versions, branch and optional directory updates..github/workflows/piplock-renewal-YYYYx.yml
as we will not use them anymore- Add.gitignore
files to block user push pipfile.lock, as from now on will be populated only bypiplock-renewal.yaml
action.Readme.md
andCONTRIBUTING.md
filesHow Has This Been Tested?
The functionality of these updates tested locally:
DIRS
for testing purposes https://github.com/atheo89/notebooks/blob/main/Makefile#L643Having optional dirs = false
https://github.com/atheo89/notebooks/actions/runs/12274941817/job/34248935523
Having optional dirs = true
https://github.com/atheo89/notebooks/actions/runs/12275077390/job/34249373408
workflow_dispatch
inputs from the user, none of them is required:Merge criteria: