Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: chore(gha): run code-server playwright tests for pushes (and scheduled run) as well #816

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

jiridanek
Copy link
Member

Description

Originally the image name was different for PR check and for the other events, and I was lazy and did not want to be solving that at the moment. It was solved in the meantime and now the test can be simply run and the image will be found and all is well.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jiridanek
Copy link
Member Author

/override ci/prow/images

not relevant for the PR

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images

not relevant for the PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/cherrypick 2024a

@openshift-cherrypick-robot

@jiridanek: once the present PR merges, I will cherry-pick it on top of 2024a in a new PR and assign it to you.

In response to this:

/cherrypick 2024a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstourac
Copy link
Member

/lgtm
/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images

In response to this:

/lgtm
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 990807f into opendatahub-io:main Dec 19, 2024
7 checks passed
@openshift-cherrypick-robot

@jiridanek: #816 failed to apply on top of branch "2024a":

Applying: NO-JIRA: chore(gha): run code-server playwright tests for pushes (and scheduled run) as well
Using index info to reconstruct a base tree...
M	.github/workflows/build-notebooks-TEMPLATE.yaml
Falling back to patching base and 3-way merge...
Auto-merging .github/workflows/build-notebooks-TEMPLATE.yaml
CONFLICT (content): Merge conflict in .github/workflows/build-notebooks-TEMPLATE.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 NO-JIRA: chore(gha): run code-server playwright tests for pushes (and scheduled run) as well

In response to this:

/cherrypick 2024a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/cherrypick 2024a

@openshift-cherrypick-robot

@jiridanek: new pull request created: #821

In response to this:

/cherrypick 2024a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants