Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: chore(owners): add myself as reviewer/approver #818

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

andyatmiami
Copy link
Contributor

Description

Adding my own GH handle (andyatmiami) to the approvers and reviewers section of OWNERS, honor alphanumeric sorting, so I can be more self-sufficient in working issues alongside the team.

How Has This Been Tested?

n/a

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Adding my own GH handle (`andyatmiami`) to the `approvers` and `reviewers` section of `OWNERS`, honor alphanumeric sorting, so I can be more self-sufficient in working issues alongside the team.
@openshift-ci openshift-ci bot requested review from jiridanek and paulovmr December 18, 2024 19:44
@caponetto
Copy link
Contributor

/lgtm

@jiridanek
Copy link
Member

/lgtm

@jiridanek
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member

/override help

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • help

Only the following failed contexts/checkruns were expected:

  • build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build
  • build (intel-runtime-pytorch-ubi9-python-3.9) / build
  • build (jupyter-intel-pytorch-ubi9-python-3.9) / build
  • build (rocm-jupyter-pytorch-ubi9-python-3.9) / build
  • build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build
  • ci/prow/images
  • pull-ci-opendatahub-io-notebooks-2023a-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

/override "build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build"
/override "build (intel-runtime-pytorch-ubi9-python-3.9) / build"
/override "build (jupyter-intel-pytorch-ubi9-python-3.9) / build"
/override "build (rocm-jupyter-pytorch-ubi9-python-3.9) / build"
/override "build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build"
/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build, build (intel-runtime-pytorch-ubi9-python-3.9) / build, build (jupyter-intel-pytorch-ubi9-python-3.9) / build, build (rocm-jupyter-pytorch-ubi9-python-3.9) / build, build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build, ci/prow/images

In response to this:

/override "build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build"
/override "build (intel-runtime-pytorch-ubi9-python-3.9) / build"
/override "build (jupyter-intel-pytorch-ubi9-python-3.9) / build"
/override "build (rocm-jupyter-pytorch-ubi9-python-3.9) / build"
/override "build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build"
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d57ab12 into opendatahub-io:main Dec 19, 2024
42 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants