Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-8388: rm(intel): Intel tensorflow notebook failed to get tested on OCP-CI so broken intel notebooks should be deleted #843

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jan 17, 2025

https://issues.redhat.com/browse/RHOAIENG-8388

Description

The Intel workbench images are broken in multiple ways and since we don't ship them, let's not even carry them on the books.

Follow-up to

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

This comment was marked as outdated.

…ted on OCP-CI

The Intel workbench images are broken in multiple ways and since we don't ship them, let's not even carry them on the books.
@jiridanek jiridanek marked this pull request as ready for review January 17, 2025 06:55
@openshift-ci openshift-ci bot requested review from atheo89 and caponetto January 17, 2025 06:55
@atheo89
Copy link
Member

atheo89 commented Jan 17, 2025

Great idea to clean up the Intel-related items as well.
While reviewing this PR, I was thinking we could keep the intel dir and Dockerfiles but remove everything related to testing and building. WDYT?

@jiridanek
Copy link
Member Author

I was thinking we could keep the intel dir and Dockerfiles

IMO it's sufficient to keep them in the git repository history, but I'm not principally opposed to having 50k lines of dead code in the notebooks repo, if that's what other people prefer.

@caponetto
Copy link
Contributor

+1 to clean everything up if keeping the files has no usage

@atheo89
Copy link
Member

atheo89 commented Jan 17, 2025

ok no objections by me

Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@jiridanek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/runtime-intel-ml-ubi9-python-3-11-pr-image-mirror dfb1524 link true /test runtime-intel-ml-ubi9-python-3-11-pr-image-mirror
ci/prow/runtime-intel-pyt-ubi9-python-3-11-pr-image-mirror dfb1524 link true /test runtime-intel-pyt-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-jupyter-intel-tf-ubi9-python-3-11-pr-image-mirror dfb1524 link true /test notebook-jupyter-intel-tf-ubi9-python-3-11-pr-image-mirror
ci/prow/runtime-intel-tf-ubi9-python-3-11-pr-image-mirror dfb1524 link true /test runtime-intel-tf-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-jupyter-intel-pyt-ubi9-python-3-11-pr-image-mirror dfb1524 link true /test notebook-jupyter-intel-pyt-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-jupyter-intel-ml-ubi9-python-3-11-pr-image-mirror dfb1524 link true /test notebook-jupyter-intel-ml-ubi9-python-3-11-pr-image-mirror
ci/prow/runtimes-ubi9-e2e-tests dfb1524 link true /test runtimes-ubi9-e2e-tests
ci/prow/intel-notebooks-e2e-tests dfb1524 link true /test intel-notebooks-e2e-tests
ci/prow/images dfb1524 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jiridanek jiridanek changed the title RHOAIENG-8388: rm(intel): Intel tensorflow notebook failed to get tested on OCP-CI RHOAIENG-8388: rm(intel): Intel tensorflow notebook failed to get tested on OCP-CI so broken intel notebooks should be deleted Jan 17, 2025
@caponetto
Copy link
Contributor

/lgtm

Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in Slack - I am going to get #834 ready for proper review today (January 17th).

If we merge #834 first and rebase this on top of it - that will at least have git History be a little more functional/helpful should we need to resurrect the intel stuff at some point in the future.

Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from caponetto. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants