fix pagination a11y errors and remaining PR comments

opendatahub-io · Mar 9, 2023 · 23f6950 · 23f6950
1 parent 3790cbb
commit 23f6950
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/frontend/src/components/Table.tsx b/frontend/src/components/Table.tsx
@@ -50,9 +50,8 @@ const Table = <T,>({
   const sort = useTableColumnSort<T>(columns, 0);
 
   const showPagination = enablePagination && allData.length > minPageSize;
-  const pagination = (pageDirection: 'up' | 'down') => (
+  const pagination = (variant: 'top' | 'bottom') => (
     <Pagination
-      dropDirection={pageDirection}
       perPageComponent="button"
       itemCount={allData.length}
       perPage={pageSize}
@@ -62,6 +61,7 @@ const Table = <T,>({
         setPageSize(newSize);
         setPage(newPage);
       }}
+      variant={variant}
       widgetId="table-pagination"
     />
   );
@@ -74,7 +74,7 @@ const Table = <T,>({
             {toolbarContent}
             {showPagination && (
               <ToolbarItem variant="pagination" alignment={{ default: 'alignRight' }}>
-                {pagination('down')}
+                {pagination('top')}
               </ToolbarItem>
             )}
           </ToolbarContent>
@@ -112,7 +112,7 @@ const Table = <T,>({
         <Toolbar>
           <ToolbarContent>
             <ToolbarItem variant="pagination" alignment={{ default: 'alignRight' }}>
-              {pagination('up')}
+              {pagination('bottom')}
             </ToolbarItem>
           </ToolbarContent>
         </Toolbar>

diff --git a/frontend/src/pages/projects/components/PasswordInput.tsx b/frontend/src/pages/projects/components/PasswordInput.tsx
@@ -9,7 +9,7 @@ const PasswordInput: React.FC<React.ComponentProps<typeof TextInput>> = (props)
     <InputGroup>
       <TextInput {...props} type={isPassword ? 'password' : 'text'} />
       <Button
-        aria-label={isPassword ? 'Show key' : 'Hide key'}
+        aria-label={isPassword ? 'Show password' : 'Hide password'}
         variant="control"
         onClick={() => setPassword(!isPassword)}
       >