Make sure nonexistent user group not change the permission of current…

… admin permission (#953)
opendatahub-io · Mar 9, 2023 · a9513ae · a9513ae
1 parent 3b5c7b8
commit a9513ae
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/backend/src/utils/adminUtils.ts b/backend/src/utils/adminUtils.ts
@@ -132,18 +132,18 @@ const checkUserInGroups = async (
   groupList: string[],
   userName: string,
 ): Promise<boolean> => {
-  try {
-    for (const group of groupList) {
+  for (const group of groupList) {
+    try {
       const groupUsers = await getGroup(customObjectApi, group);
       if (
         groupUsers?.includes(userName) ||
         groupUsers?.includes(`${KUBE_SAFE_PREFIX}${userName}`)
       ) {
         return true;
       }
+    } catch (e) {
+      fastify.log.error(e.toString());
     }
-  } catch (e) {
-    fastify.log.error(e.toString());
   }
   return false;
 };