Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display user defined threshold values on charts #1163

Closed
alexcreasy opened this issue Apr 20, 2023 · 0 comments
Closed

Display user defined threshold values on charts #1163

alexcreasy opened this issue Apr 20, 2023 · 0 comments
Assignees
@alexcreasy
Labels
feature/model-serving Model Serving Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Milestone
Explainability Ph...

Comments

@alexcreasy
Copy link
Contributor

alexcreasy commented Apr 20, 2023 •
edited
Loading

Goal

Modify the chart components to display user defined thresholds, if defined, or defaults if not

Dependency issue

Itemized goals

  • Convert current threshold display (which currently has separate values for MIN and MAX to a single threshold value. NOTE: two threshold lines are still required at +ve and -ve threshold, but there will now be one value.
  • Display chart threshold with value the user has configured (provided by trusty AI service as part of the metric definition).
  • If no threshold is configured by the user, the current hard coded thresholds should be displayed (note these are different depending not he chart type e.g. SPD, DIR)

NB: The thresholds are the dashed red lines as seen in the charts on the mock.

Aspects continued elsewhere

No response

Mocks

b7744e30-9eb4-49ea-9138-b3c547572887
@alexcreasy alexcreasy added the priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. label Apr 20, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in ODH Dashboard Planning Apr 20, 2023
@alexcreasy alexcreasy mentioned this issue Apr 20, 2023
Closed
@Gkrumbach07 Gkrumbach07 added this to the Explainability Phase 1 milestone Apr 25, 2023
@Gkrumbach07 Gkrumbach07 moved this from Needs prioritization to To do in ODH Dashboard Planning Apr 25, 2023
@alexcreasy alexcreasy added the feature/model-serving Model Serving Feature label May 22, 2023
@alexcreasy alexcreasy changed the title User defined thresholds Display user defined threshold values on charts May 22, 2023
@alexcreasy alexcreasy self-assigned this Jun 8, 2023
@alexcreasy alexcreasy moved this from To do to In progress in ODH Dashboard Planning Jun 9, 2023
@alexcreasy alexcreasy mentioned this issue Jun 9, 2023
Merged
6 tasks
alexcreasy added a commit to alexcreasy/odh-dashboard that referenced this issue Jun 10, 2023
@alexcreasy
Multi-metric display on model bias screen (opendatahub-io#1273)
c970ccb 
  * Enhancements to model bias screen

  * Display of multiple bias charts simultaneously

  * Multi-select component, allowing free text, or select-from-list selection of chartst to display

  * Ability to collapse / expand individual charts

  * User selectable refresh rates of chart data

  * Chart selection and open / closed status is persisted to session cache for life of user's browser session

Display user defined threshold values on charts (opendatahub-io#1163)

  * Clean up of bias chart logic

  * Displays thresholds chosen by user, or defaults if none.

  * Improves domain and threshold calculation based on user values or defaults
openshift-merge-robot pushed a commit that referenced this issue Jun 12, 2023
@alexcreasy
Multi-metric display on model bias screen (#1273) (#1349)
694ada2 
* Enhancements to model bias screen

  * Display of multiple bias charts simultaneously

  * Multi-select component, allowing free text, or select-from-list selection of chartst to display

  * Ability to collapse / expand individual charts

  * User selectable refresh rates of chart data

  * Chart selection and open / closed status is persisted to session cache for life of user's browser session

Display user defined threshold values on charts (#1163)

  * Clean up of bias chart logic

  * Displays thresholds chosen by user, or defaults if none.

  * Improves domain and threshold calculation based on user values or defaults
@alexcreasy alexcreasy moved this from In progress to Done in ODH Dashboard Planning Jun 12, 2023
openshift-merge-robot pushed a commit that referenced this issue Jun 30, 2023
@DaoDaoNoCode @andrewballantyne @alexcreasy
Bias to incubation (#1449)
bb8e2c5 
* Re-enable Metrics

* Fix Graphs & Configure Infrastructure (#1023)

* Rework Inference Metrics & Add Runtime Metrics (invalid quieries)

* Add stacked line chart functionality

* Trustyai demo phase0 (#1093)

* Explainability: Fairness and Bias Metrics (Phase 0) (#1001) (#1006) (#1007) (#1008)
  - Initial feature set for TrustyAI related UI functionality
  - Adds tab based navigation to modelServing screen
  - Adds a bias metrics tab with charts for visualising SPD and DIR metrics
  - Enhances prometheus query features for accessing TrustyAI data
  - Enhacements to MetricsChart component making it more configurable

* Update key of request name to match trusty backend

* Remove unnecessary div and inline style from tooltip

* Remove 15 minutes refresh option

* Prefer optional prop to type union with undefined

* Move function definitions inline

* Prefer narrowing over type conversion

* Inline tab change handler

* Remove toolbar option from ApplicationsPage

* Inline domain calculator functions

* Move defaultDomainCalculator to utils

* Return null instead of undefined

* Use threshold label instead of index for key

* Add enum for tab keys

* Remove magic numbers from domain calculations

* Make ResponsePredicate mandatory and add predicate to useQueryRangeResourceData

* TrustyAI Client (#1318)

* Add support for insecure http requests in development mode

* Adds low level API client for TrustyAI service

* Adds TrustyAI high level API and contexts

* Get scheme of TrustyAI route from k8s data

* Add model bias configuration table (#1290)

* Add model bias configuration table

* rebase and remove mock data

* Update Trusty AI client to handle API changes (#1336) (#1337)

* Add bias metrics configuration modal (#1343)

* Add configuration modal

* address comments

* get rid of some TODOs and refine the route

* Multi-metric display on model bias screen (#1273) (#1349)

* Enhancements to model bias screen

  * Display of multiple bias charts simultaneously

  * Multi-select component, allowing free text, or select-from-list selection of chartst to display

  * Ability to collapse / expand individual charts

  * User selectable refresh rates of chart data

  * Chart selection and open / closed status is persisted to session cache for life of user's browser session

Display user defined threshold values on charts (#1163)

  * Clean up of bias chart logic

  * Displays thresholds chosen by user, or defaults if none.

  * Improves domain and threshold calculation based on user values or defaults

* Fix metrics submission issue and handle errors (#1378)

* Fix metrics submission issue and handle errors

* fix lint issue

* use error handler on GET functions

* Default and restrict threshold, add tooltips, default duplicate name and set feature flag (#1390)

* Default and restrict threshold, add tooltips, default duplicate name and set feature flag

* fix lint

* add tooltips and dropdown descriptions

* clear data when closing configuration modal

* really solve deleting issue, make empty table view a common component and apply it everywhere

* address comments

* Minor enhancements to bias chart (#1386) (#1399)

* Adds refresh interval options that match openshift observability dashboard

* Show first chart from list, if none selected when user first navigates to bias tab

* Use search icon instead of plus for nothing selected empty state

* Fix error with calculation of 30 days constant

* Deleted charts are removed from session storage

* Fixes issue with bias charts auto-refreshing with stale data (#1403) (#1404)

* Refactor prometheus queries to remove duplication

* Fix graph not refreshing issue

* Add code review suggestions

* Add performance metrics feature flag and refactor runtime server route (#1413)

* Add performance metrics feature flag, refactor runtime server route and solve layout issues

* revert some style changes

* Model serving metrics renaming (#1421)

* Adds support for TrustyAI Operator (#1443)

* Adds support for TrustyAI Operator (#1276)

* Changes from feedback

---------

Co-authored-by: Andrew Ballantyne <aballant@redhat.com>
Co-authored-by: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com>
Co-authored-by: Alex Creasy <acreasy@redhat.com>
Co-authored-by: Alex Creasy <arcreasy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcreasy alexcreasy

Labels
feature/model-serving Model Serving Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
No open projects
ODH Dashboard Planning
Archived in project
Milestone
Explainability Phase 1
Development

No branches or pull requests
2 participants
@alexcreasy @Gkrumbach07