Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Story]: Add project name to the session storage key for the selected metrics chart #2022

Closed
alexcreasy opened this issue Oct 27, 2023 · 0 comments · Fixed by #2070
Closed

[Story]: Add project name to the session storage key for the selected metrics chart #2022

alexcreasy opened this issue Oct 27, 2023 · 0 comments · Fixed by #2070
Assignees
@pnaik1
Labels
feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@alexcreasy
Copy link
Contributor

Goal

Prevent a potential issue if a model with the same name exists in multiple projects and both are used for bias detection

Dependency issue

No dependencies

Itemized goals

The key for the session variable that holds the user's chart selections can be found here[1]. The project name should form part of the key name as well as the inference service name.

[1]https://github.com/opendatahub-io/odh-dashboard/blob/3b82db37f3cb9b8ec43c9fd2f35a1f434eb9f75b/frontend/src/pages/modelServing/screens/metrics/useBiasChartsBrowserStorage.ts

Aspects continued elsewhere

No response

Mocks

No mocks
@alexcreasy alexcreasy added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. labels Oct 27, 2023
This was referenced Oct 27, 2023
Closed
Closed
@alexcreasy alexcreasy self-assigned this Oct 27, 2023
@alexcreasy alexcreasy moved this from Untriaged to Dev To do in ODH Dashboard Planning Oct 27, 2023
@alexcreasy alexcreasy moved this to Todo in Internal tracking Oct 27, 2023
@alexcreasy alexcreasy assigned pnaik1 and unassigned alexcreasy Nov 1, 2023
@pnaik1 pnaik1 moved this from Dev To do to Dev In progress in ODH Dashboard Planning Nov 1, 2023
@pnaik1 pnaik1 mentioned this issue Nov 6, 2023
Merged
7 tasks
@pnaik1 pnaik1 linked a pull request Nov 6, 2023 that will close this issue
Add project name to the session storage key for the selected metrics … #2070
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Internal tracking Nov 8, 2023
@github-project-automation github-project-automation bot moved this from Dev In progress to Done in ODH Dashboard Planning Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnaik1 pnaik1

Labels
feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
Internal tracking
Status: Done
ODH Dashboard Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add project name to the session storage key for the selected metrics … pnaik1/odh-dashboard
2 participants
@alexcreasy @pnaik1