Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project name to the session storage key for the selected metrics … #2070

Merged

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Nov 6, 2023

Closes: #2022

Description

The key for the session variable that holds the user's chart selections can be found here[1]. The project name should form part of the key name as well as the inference service name.

How Has This Been Tested?

Navigate to the bias metrics tab
From the selector, select a chart
Open the browser console (F12) -> Applications tab
From the 'storage' group on the left menu bar, expand 'Session Storage'
In the main tab, look for a key that will be of the format: 'odh.dashboard.xai.selected_bias_charts-$PROJECT_NAME-$MODEL_NAME'
It should contain a project name
Screenshot from 2023-11-06 18-51-13

Test Impact

No test cases

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

@alexcreasy alexcreasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pnaik1 - I found one bug in your implementation. It works well when using the global model serving route, but when you access via the projects route, the project is undefined. See screenshot
bug_1

@pnaik1
Copy link
Contributor Author

pnaik1 commented Nov 8, 2023

updated the changes

@openshift-ci openshift-ci bot added the lgtm label Nov 8, 2023
Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 8, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 453f440 into opendatahub-io:f/mserving-metrics Nov 8, 2023
3 checks passed
@pnaik1 pnaik1 deleted the issue-2022 branch July 22, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story]: Add project name to the session storage key for the selected metrics chart
2 participants