Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Reusable Table Component #961

Closed
andrewballantyne opened this issue Feb 17, 2023 · 0 comments · Fixed by #978
Closed

[Feature Request]: Reusable Table Component #961

andrewballantyne opened this issue Feb 17, 2023 · 0 comments · Fixed by #978
Assignees
@Gkrumbach07
Labels
feature/ds-pipelines Data Science Pipelines feature (aka DSP) feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) feature/model-serving Model Serving Feature kind/enhancement New functionality request (existing augments or new additions) priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Milestone
v2.8.0

Comments

@andrewballantyne
Copy link
Member

Feature description

We have already a few tables in our application (search: TableComposable) already.

In the upcoming Data Science Pipelines (#923) feature, we'll be needing more tables. It's time we take our tables and unify them to avoid reimplementation of pagination, sorting, and delegating rendering to the caller. Should be able to take existing usages and make it a singular component with smart props.

Describe alternatives you've considered

No response

Anything else?

See @andrewballantyne when you are structuring the table to work it out early beforehand.
@andrewballantyne andrewballantyne added kind/enhancement New functionality request (existing augments or new additions) untriaged Indicates the newly create issue has not been triaged yet priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) feature/model-serving Model Serving Feature feature/ds-pipelines Data Science Pipelines feature (aka DSP) and removed untriaged Indicates the newly create issue has not been triaged yet labels Feb 17, 2023
@andrewballantyne andrewballantyne moved this from Backlog to To do in ODH Dashboard Planning Feb 17, 2023
@andrewballantyne andrewballantyne added this to the Next Release milestone Feb 17, 2023
@Gkrumbach07 Gkrumbach07 moved this from To do to In progress in ODH Dashboard Planning Feb 22, 2023
@Gkrumbach07 Gkrumbach07 mentioned this issue Feb 23, 2023
Merged
3 tasks
@Gkrumbach07 Gkrumbach07 moved this from In progress to In review in ODH Dashboard Planning Feb 27, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ODH Dashboard Planning Mar 3, 2023
@dchourasia dchourasia mentioned this issue Jul 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gkrumbach07 Gkrumbach07

Labels
feature/ds-pipelines Data Science Pipelines feature (aka DSP) feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) feature/model-serving Model Serving Feature kind/enhancement New functionality request (existing augments or new additions) priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
No open projects
ODH Dashboard Planning
Archived in project
Milestone
v2.8.0
Development

Successfully merging a pull request may close this issue.

Create general purpose Table component Gkrumbach07/odh-dashboard
2 participants
@andrewballantyne @Gkrumbach07