Create general purpose Table component #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
frontend/src/pages/projects/screens/projects/ProjectListView.tsx
Outdated
Show resolved
Hide resolved
Gkrumbach07
changed the title
Gkrumbach07
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
andrewballantyne
requested changes
Feb 28, 2023
Gkrumbach07
force-pushed
the
combined-table
branch
from
c2965e4 to
6ce3469
Compare
DaoDaoNoCode
requested changes
Mar 1, 2023
frontend/src/pages/projects/screens/projects/ProjectListView.tsx
Outdated
Show resolved
Hide resolved
this is b/c some table rows use a tbody when they should really just implement a row I will go remove the instances of those i find |
andrewballantyne
requested changes
Mar 1, 2023
frontend/src/pages/modelServing/screens/projects/ServingRuntimeTableRow.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/projects/screens/detail/notebooks/NotebookTableRow.tsx
Outdated
Show resolved
Hide resolved
lucferbux
requested changes
Mar 3, 2023
andrewballantyne
requested changes
Mar 3, 2023
andrewballantyne
requested changes
Mar 3, 2023
frontend/src/pages/modelServing/screens/global/InferenceServiceTable.tsx
Show resolved
Hide resolved
frontend/src/pages/modelServing/screens/global/InferenceServiceTable.tsx
Show resolved
Hide resolved
DaoDaoNoCode
reviewed
Mar 3, 2023
frontend/src/pages/modelServing/screens/global/InferenceServiceListView.tsx
Outdated
Show resolved
Hide resolved
Gkrumbach07
force-pushed
the
combined-table
branch
2 times, most recently
from
d7e9bf7 to
f0d62ff
Compare
andrewballantyne
requested changes
Mar 3, 2023
frontend/src/pages/modelServing/screens/global/InferenceServiceListView.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelServing/screens/global/InferenceServiceListView.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelServing/screens/global/InferenceServiceTable.tsx
Outdated
Show resolved
Hide resolved
delete unused projectTable comp
Gkrumbach07
force-pushed
the
combined-table
branch
from
9391ef6 to
cb8891d
Compare
andrewballantyne
approved these changes
Mar 3, 2023
andrewballantyne
approved these changes
Mar 3, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lucferbux
pushed a commit
to lucferbux/odh-dashboard
that referenced
this pull request
Mar 13, 2023
* implemented general Table component delete unused projectTable comp * added tbody fix * fixed pagination
bartoszmajsak
pushed a commit
to maistra/odh-dashboard
that referenced
this pull request
Mar 30, 2023
* implemented general Table component delete unused projectTable comp * added tbody fix * fixed pagination
strangiato
pushed a commit
to strangiato/odh-dashboard
that referenced
this pull request
Oct 18, 2023
* implemented general Table component delete unused projectTable comp * added tbody fix * fixed pagination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #961
Description
Create a Table component that handles
Other toolbar items can be added through a toolbar param
How Has This Been Tested?
make sure all instances of tables work the same the they did before:
odh-dashboard/frontend/src/pages/BYONImages/BYONImagesTable.tsxodh-dashboard/frontend/src/pages/BYONImages/ImportImageModal.tsxodh-dashboard/frontend/src/pages/BYONImages/UpdateImageModal.tsxMerge criteria: