Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added accelerator CRD #1451

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Added accelerator CRD #1451

merged 3 commits into from
Jul 3, 2023

Conversation

Gkrumbach07
Copy link
Member

closes: #1371

Description

add a CRD to the manifest folder to represent accelerator devices

How Has This Been Tested?

  • apply this yaml in opendatahub

Test Impact

n/a backend

Request review criteria:

  • The commits have meaningful messages (squashes happen on merge by the bot).
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

@openshift-ci openshift-ci bot requested review from alexcreasy and lucferbux June 29, 2023 19:22
lucferbux
lucferbux approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 30, 2023
@lucferbux lucferbux removed the lgtm label Jun 30, 2023
@lucferbux lucferbux self-requested a review June 30, 2023 10:53
lucferbux
lucferbux approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ff64ff2 into opendatahub-io:accelerator-support Jul 3, 2023
@andrewballantyne
Copy link
Member

After the fact review -- Looks good, modified date probably still needs to be thought on if it needs to be a property or not. We'll also need to look into tolerations and how that'll work too.

Likely a read through of https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/ to figure out what we need to make it happen.

Gkrumbach07 added a commit to Gkrumbach07/odh-dashboard that referenced this pull request Aug 10, 2023
@Gkrumbach07
Added accelerator CRD (opendatahub-io#1451)
55231c7 
* added cr

* added accelerator profile crd

* added to kustomize

add copy to clipboard to k8 name popover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucferbux lucferbux lucferbux approved these changes

@alexcreasy alexcreasy Awaiting requested review from alexcreasy

Assignees

@lucferbux lucferbux

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gkrumbach07 @andrewballantyne @lucferbux @openshift-merge-robot