Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1863
Description
There is a problem in gpu detection reduce function. When the detection iterates over each accelerator, it determines enablement by this logic
prevConfigured ?? checkConfigured()
. The issue was that we used??
which would cause the configured var to always be false if it started as false becausefalse ?? true
is still false. This PR uses||
instead which would give the correct resultfalse || true = true
How Has This Been Tested?
migrated-gpu
accelerator should be addedTest Impact
no test impact -> hot fix
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main