-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-6985] Create kserve metrics feature flag #2795
[RHOAIENG-6985] Create kserve metrics feature flag #2795
Conversation
320c84f
to
4f96037
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good, however I found an issue in testing.
When ModelMesh is disabled in the DSC but Kserve is enabled there are two issues:
- There is no link to the metrics page from the data science project details route
- Whilst there is a link from the Global model serving route, the link is broken and ends up with an infinity spinner.
This could have something to do with how the model metrics area is defined - right now it depends on modelmesh being installed, which might contribute to this issue?
4f96037
to
758b1cd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2795 +/- ##
==========================================
+ Coverage 77.32% 77.45% +0.12%
==========================================
Files 1093 1093
Lines 23026 23043 +17
Branches 5799 5808 +9
==========================================
+ Hits 17805 17848 +43
+ Misses 5221 5195 -26
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
758b1cd
to
7a48046
Compare
@jeff-phillips-18 there's just one more thing I've noticed: Otherwise all good! |
7a48046
to
ebd48f4
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexcreasy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ebd48f4
to
b5648a4
Compare
/lgtm |
Closes: RHOAIENG-6985
Description
Initial creation fo the kserve metric feature, disabled by default. Includes a simple
Coming soon
page.How Has This Been Tested?
Tested locally and added e2e tests
Test Impact
Verify that the user can navigate to the kserve metrics page from the model list view by clicking on the model name ONLY if the feature flag is enabled.
Screen shots
Request review criteria: