Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Collapse All" and "Expand All" actions to control bar in topology view #2886

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Jun 6, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-7430

Description

Add "Collapse All" and "Expand All" actions to control bar in topology view.

Screenshot 2024-06-06 at 3 32 22 PM Screenshot 2024-06-06 at 3 32 34 PM

How Has This Been Tested?

  1. Open a pipeline or run.
  2. Click "Collapse All" or "Expand All" action in control bar.
  3. Verify that the expand/collapse works as expected.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from alexcreasy and pnaik1 June 6, 2024 19:40
@jenny-s51 jenny-s51 force-pushed the RHOAIENG-7430 branch 2 times, most recently from fe5f411 to 4dbf988 Compare June 6, 2024 20:35
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 4.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 78.82%. Comparing base (2f76c11) to head (b47f9cd).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2886      +/-   ##
==========================================
- Coverage   78.89%   78.82%   -0.08%     
==========================================
  Files        1112     1112              
  Lines       23554    23579      +25     
  Branches     5931     5935       +4     
==========================================
+ Hits        18584    18585       +1     
- Misses       4970     4994      +24     
Files Coverage Δ
...concepts/topology/PipelineVisualizationSurface.tsx 34.48% <4.00%> (-23.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f76c11...b47f9cd. Read the comment docs.

@Gkrumbach07
Copy link
Member

This looks good

/lgtm

waiting on one more review

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works well. Just one question, I saw a lot of console print and looks like they are from the PF topology component. Is there a way to silence them or will there be a fix to remove those console messages?

Screenshot 2024-06-07 at 3 51 17 PM

Copy link
Contributor Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @DaoDaoNoCode , opened an issue upstream: patternfly/react-topology#217

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second review is good. we can merge

/approve

Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0a0963a into opendatahub-io:main Jun 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants