-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Collapse All" and "Expand All" actions to control bar in topology view #2886
Add "Collapse All" and "Expand All" actions to control bar in topology view #2886
Conversation
fe5f411
to
4dbf988
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2886 +/- ##
==========================================
- Coverage 78.89% 78.82% -0.08%
==========================================
Files 1112 1112
Lines 23554 23579 +25
Branches 5931 5935 +4
==========================================
+ Hits 18584 18585 +1
- Misses 4970 4994 +24
Continue to review full report in Codecov by Sentry.
|
This looks good /lgtm waiting on one more review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @DaoDaoNoCode , opened an issue upstream: patternfly/react-topology#217
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second review is good. we can merge
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA: https://issues.redhat.com/browse/RHOAIENG-7430
Description
Add "Collapse All" and "Expand All" actions to control bar in topology view.
How Has This Been Tested?
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main