Begin data connection clean up

[ashley-o0o]

Closes: RHOAIENG-15563

Description

This PR begins to clean up old code from data connections. Removes the isConnectionTypesEnabled feature flag from the list of options, and cleans up some Cypress code related to testing data connections

How Has This Been Tested?

tested locally

Test Impact

Cypress tests updated to remove some data connections tests

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[emilys314]

Hey you started removing connections (the new code) instead of the data connections (the old stuff) can you check the rest of your PR? thanks

[manaswinidas]

FYI This will cause merge conflicts with #3590 - depending on what goes in first

[codecov]

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.48%. Comparing base (f398f85) to head (29e3643).
Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
...il/overview/configuration/ConfigurationSection.tsx	50.00%	1 Missing ⚠️
...src/pages/projects/screens/spawner/SpawnerPage.tsx	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3660      +/-   ##
==========================================
- Coverage   84.15%   83.48%   -0.67%     
==========================================
  Files        1453     1453              
  Lines       33866    33787      -79     
  Branches     9384     9363      -21     
==========================================
- Hits        28499    28207     -292     
- Misses       5367     5580     +213     

Files with missing lines	Coverage Δ
frontend/src/app/AppRoutes.tsx	94.00% <ø> (-0.34%)	⬇️
frontend/src/components/TypeaheadSelect.tsx	67.58% <ø> (-0.18%)	⬇️
frontend/src/concepts/areas/const.ts	100.00% <ø> (ø)
frontend/src/concepts/areas/types.ts	100.00% <ø> (ø)
frontend/src/k8sTypes.ts	100.00% <ø> (ø)
...rontend/src/pages/home/aiFlows/ProjectsGallery.tsx	94.11% <ø> (+4.11%)	⬆️
...erenceServiceModal/ManageInferenceServiceModal.tsx	96.92% <100.00%> (+3.17%)	⬆️
...screens/projects/kServeModal/ManageKServeModal.tsx	95.03% <100.00%> (+0.84%)	⬆️
...c/pages/projects/screens/detail/ProjectDetails.tsx	96.42% <ø> (-0.35%)	⬇️
...c/pages/projects/screens/spawner/SpawnerFooter.tsx	83.94% <100.00%> (-0.35%)	⬇️
... and 3 more

... and 45 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f398f85...29e3643. Read the comment docs.

[emilys314]

Also how much are we going to remove? The PR states it's the beginning, but the jira item implies all?

Additionally you have some orphaned files you can remove related to data connections to, like the entire folder of frontend/src/pages/projects/screens/detail/data-connections

[ashley-o0o]

@emilys314 The plan is to remove it all, but we had discussed just starting with the removal of the feature flag and conditionally rendered code related to it, as well as fixing some of the test cases to use connections. A second deliverable would be removal of the remaining dead code. I assumed that it might be easier to open a second jira ticket for that, but unsure.

[Griffin-Sullivan]

/lgtm Tested locally and everything worked as I expected. Code changes seem reasonable but I'll leave it up to the experts 😄

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment