Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline run details page input parameters correctly parse string object #3675

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Jan 23, 2025

https://issues.redhat.com/browse/RHOAIENG-16418

Description

  • The input parameter scroll is already been addressed in some other PR
  • This pr aims at correctly parsing the string object
Screen.Recording.2025-01-23.at.8.54.56.PM.mov

How Has This Been Tested?

  • Import a pipeline with more than 20 parameter, verify if the scrolling is present
  • Import a pipeline with parameter of string value object and check if the code block is present

Test Impact

Added Cypress test cases

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.26%. Comparing base (4d76fc1) to head (a57274b).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...esDetails/pipelineRun/PipelineRunTabParameters.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3675      +/-   ##
==========================================
+ Coverage   84.23%   84.26%   +0.02%     
==========================================
  Files        1450     1450              
  Lines       33769    33774       +5     
  Branches     9355     9357       +2     
==========================================
+ Hits        28447    28459      +12     
+ Misses       5322     5315       -7     
Files with missing lines Coverage Δ
...esDetails/pipelineRun/PipelineRunTabParameters.tsx 71.11% <83.33%> (+1.11%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d713a...a57274b. Read the comment docs.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f398f85 into opendatahub-io:main Jan 30, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants