Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added form limits for workbench, PVC, and project resource names #3698

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

rsun19
Copy link
Contributor

@rsun19 rsun19 commented Jan 29, 2025

RHOAIENG-13679

Description

Workbench storage resource names are now capped at 63 characters. Project and workbench resource names are now capped at 30 characters.

Screenshot 2025-01-29 at 11 56 28 AM

How Has This Been Tested?

Visually, you can see the resource name enforcement if you make a new PVC in workbench, make a new workbench, and make a new Project. If you put in absurd values for names, it should be converted with the max length.

Test Impact

Added unit tests

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Sorry, something went wrong.

@openshift-ci openshift-ci bot requested review from alexcreasy and dpanshug January 29, 2025 17:05
@rsun19 rsun19 changed the title added form limits for workbench, PVC, and project resource names [wip] added form limits for workbench, PVC, and project resource names Jan 29, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (be0ba94) to head (de76838).
Report is 26 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3698      +/-   ##
==========================================
- Coverage   84.26%   84.17%   -0.10%     
==========================================
  Files        1450     1453       +3     
  Lines       33766    33869     +103     
  Branches     9353     9384      +31     
==========================================
+ Hits        28454    28509      +55     
- Misses       5312     5360      +48     
Files with missing lines Coverage Δ
.../src/concepts/k8s/K8sNameDescriptionField/utils.ts 98.46% <100.00%> (+0.07%) ⬆️
...creens/spawner/storage/CreateNewStorageSection.tsx 96.55% <ø> (ø)

... and 38 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0ba94...de76838. Read the comment docs.

@rsun19 rsun19 changed the title [wip] added form limits for workbench, PVC, and project resource names added form limits for workbench, PVC, and project resource names Jan 29, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jan 29, 2025
@rsun19
Copy link
Contributor Author

rsun19 commented Jan 29, 2025

The ticket asks for the resource name to be validated for duplicates, but useNotebookPVCItems does not provide resource names

@rsun19 rsun19 force-pushed the enforce-form-limits branch from bcb3cf8 to 3740fb3 Compare January 29, 2025 21:27

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@rsun19 rsun19 force-pushed the enforce-form-limits branch from 3740fb3 to de76838 Compare January 30, 2025 14:33
@Gkrumbach07
Copy link
Member

@andrewballantyne are all your comments resolved?

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good

ヽ༼ຈل͜ຈ༽ノ

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 89f3e20 into opendatahub-io:main Jan 30, 2025
29 checks passed
ashley-o0o pushed a commit to ashley-o0o/odh-dashboard that referenced this pull request Feb 7, 2025
ugiordan pushed a commit to ugiordan/odh-dashboard that referenced this pull request Feb 10, 2025
manaswinidas pushed a commit to manaswinidas/odh-dashboard that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants