-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added form limits for workbench, PVC, and project resource names #3698
added form limits for workbench, PVC, and project resource names #3698
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3698 +/- ##
==========================================
- Coverage 84.26% 84.17% -0.10%
==========================================
Files 1450 1453 +3
Lines 33766 33869 +103
Branches 9353 9384 +31
==========================================
+ Hits 28454 28509 +55
- Misses 5312 5360 +48
... and 38 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
The ticket asks for the resource name to be validated for duplicates, but |
bcb3cf8
to
3740fb3
Compare
3740fb3
to
de76838
Compare
@andrewballantyne are all your comments resolved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good
ヽ༼ຈل͜ຈ༽ノ
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
89f3e20
into
opendatahub-io:main
RHOAIENG-13679
Description
Workbench storage resource names are now capped at 63 characters. Project and workbench resource names are now capped at 30 characters.
How Has This Been Tested?
Visually, you can see the resource name enforcement if you make a new PVC in workbench, make a new workbench, and make a new Project. If you put in absurd values for names, it should be converted with the max length.
Test Impact
Added unit tests
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main