-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GitHub action] Replace Quay image URL #3699
[GitHub action] Replace Quay image URL #3699
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3699 +/- ##
=======================================
Coverage 84.15% 84.16%
=======================================
Files 1453 1453
Lines 33866 33866
Branches 9384 9384
=======================================
+ Hits 28500 28502 +2
+ Misses 5366 5364 -2 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@manaswinidas also tested on her own fork https://github.com/manaswinidas/odh-dashboard/actions/runs/13057310033/job/36431499524 and it seems to pass when editing the variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp to help have usages for tomorrow.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, Griffin-Sullivan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e53fa01
into
opendatahub-io:main
my2c: if I can see this secret is also being referenced here but this workflow has been failing for a while. |
Replace
QUAY_ODH_DASHBOARD_IMAGE_REPO
withquay.io/repository/opendatahub/odh-dashboard
coz the GitHub action is failing and DevOps advised to use the image URL instead. This change is made to thecreate-tag
action only.Description
Followed this doc to make the changes. GitHub action whisperers welcome to correct me.
How Has This Been Tested?
Can test it once this PR is merged and I run the action.
Tested on my fork with one of my own Quay repos: https://github.com/manaswinidas/odh-dashboard/actions/runs/13057310033
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main