Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub action] Replace Quay image URL #3699

Merged

Conversation

manaswinidas
Copy link
Contributor

@manaswinidas manaswinidas commented Jan 30, 2025

Replace QUAY_ODH_DASHBOARD_IMAGE_REPO with quay.io/repository/opendatahub/odh-dashboard coz the GitHub action is failing and DevOps advised to use the image URL instead. This change is made to the create-tag action only.

Description

Followed this doc to make the changes. GitHub action whisperers welcome to correct me.

How Has This Been Tested?

Can test it once this PR is merged and I run the action.
Tested on my fork with one of my own Quay repos: https://github.com/manaswinidas/odh-dashboard/actions/runs/13057310033

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (240a695) to head (fa76129).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3699   +/-   ##
=======================================
  Coverage   84.15%   84.16%           
=======================================
  Files        1453     1453           
  Lines       33866    33866           
  Branches     9384     9384           
=======================================
+ Hits        28500    28502    +2     
+ Misses       5366     5364    -2     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 240a695...fa76129. Read the comment docs.

Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Griffin-Sullivan
Copy link
Contributor

@manaswinidas also tested on her own fork https://github.com/manaswinidas/odh-dashboard/actions/runs/13057310033/job/36431499524 and it seems to pass when editing the variables.

Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp to help have usages for tomorrow.

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e53fa01 into opendatahub-io:main Jan 30, 2025
29 checks passed
@caponetto
Copy link

my2c:

if QUAY_ODH_DASHBOARD_IMAGE_REPO was stored in an "Action Secret" so it could be changed across different forks more easily or shared between workflows, you could have used "Action Variable" instead and call ${{ vars.QUAY_ODH_DASHBOARD_IMAGE_REPO }} on the workflow code.

I can see this secret is also being referenced here but this workflow has been failing for a while.

ashley-o0o pushed a commit to ashley-o0o/odh-dashboard that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants