Address a11y violations in Resources screen(s) #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package-lock.json
jenny-s51
changed the title
jenny-s51
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Gkrumbach07
reviewed
Feb 21, 2023
lucferbux
approved these changes
Feb 23, 2023
DaoDaoNoCode
approved these changes
Feb 23, 2023
andrewballantyne
requested changes
Feb 23, 2023
jenny-s51
force-pushed
the
resourcesA11y
branch
from
cf3cd4d to
3706982
Compare
jenny-s51
force-pushed
the
resourcesA11y
branch
from
f783080 to
571b1da
Compare
andrewballantyne
approved these changes
Feb 23, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, DaoDaoNoCode, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tested, looks good. /unhold |
bartoszmajsak
pushed a commit
to maistra/odh-dashboard
that referenced
this pull request
Mar 30, 2023
* fix a11y violations in resources screen package-lock.json * remove role from Gallery * prettier * unique ids * prettier * PR feedback from Andrew * prettier
strangiato
pushed a commit
to strangiato/odh-dashboard
that referenced
this pull request
Oct 18, 2023
* fix a11y violations in resources screen package-lock.json * remove role from Gallery * prettier * unique ids * prettier * PR feedback from Andrew * prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #966
How Has This Been Tested?
Before (Card View):
After (Card View):
Before (List View):
After (List View):
Before and After Empty State - no violations:
Merge criteria: