Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI issues #976

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Fix UI issues #976

merged 1 commit into from
Feb 23, 2023
+11 −6

Conversation

lucferbux
Copy link
Contributor

Description

Fixes #960

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Sorry, something went wrong.

@openshift-ci openshift-ci bot requested a review from Gkrumbach07 February 23, 2023 14:10
andrewballantyne
andrewballantyne approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Code looks good -- I need to test it out once I get a moment

@openshift-ci openshift-ci bot added do-not-merge/hold This PR is hold for some reason lgtm approved labels Feb 23, 2023
Gkrumbach07
Gkrumbach07 approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it and it all works.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gkrumbach07
Copy link
Member

/lgtm

@andrewballantyne andrewballantyne removed the do-not-merge/hold This PR is hold for some reason label Feb 23, 2023
@andrewballantyne
Copy link
Member

Tested -- works great. Bit unsure of the desired text changes, but it did come from UX 🙂

@openshift-merge-robot openshift-merge-robot merged commit c9d837c into opendatahub-io:main Feb 23, 2023
bartoszmajsak pushed a commit to maistra/odh-dashboard that referenced this pull request Mar 30, 2023
@lucferbux @bartoszmajsak
Fix UI issues (opendatahub-io#976)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e6a6aa3
strangiato pushed a commit to strangiato/odh-dashboard that referenced this pull request Oct 18, 2023
@lucferbux @strangiato
Fix UI issues (opendatahub-io#976)
ffe3c95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewballantyne andrewballantyne

@Gkrumbach07 Gkrumbach07

@DaoDaoNoCode DaoDaoNoCode

Assignees

@andrewballantyne andrewballantyne

@Gkrumbach07 Gkrumbach07

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Minor UI issues
4 participants
@lucferbux @Gkrumbach07 @andrewballantyne @openshift-merge-robot