Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update away from org PR Template #980

Merged

Conversation

andrewballantyne
Copy link
Member

Our current template does not resonate closely with a UI effort.

Creating the template according to https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

@openshift-ci openshift-ci bot requested review from Gkrumbach07 and lucferbux March 1, 2023 14:00
@Gkrumbach07
Copy link
Member

I assume frontmatter is not needed as this is the only template. Would we want other templates for bugs vs features?

@andrewballantyne
Copy link
Member Author

andrewballantyne commented Mar 1, 2023

I assume frontmatter is not needed as this is the only template. Would we want other templates for bugs vs features?

I thought of that -- we could definitely go down that path -- but in the end I suspect it will not be a lot different.

I'm open to opinions if people think it's important to try and have different templates, but in my experience a bug template and a feature template equate to very similar templates (for PRs)

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2723702 into opendatahub-io:main Mar 3, 2023
lucferbux pushed a commit to lucferbux/odh-dashboard that referenced this pull request Mar 13, 2023
* Update away from org PR Template

* Added testing to checklist
bartoszmajsak pushed a commit to maistra/odh-dashboard that referenced this pull request Mar 30, 2023
* Update away from org PR Template

* Added testing to checklist
strangiato pushed a commit to strangiato/odh-dashboard that referenced this pull request Oct 18, 2023
* Update away from org PR Template

* Added testing to checklist
@andrewballantyne andrewballantyne deleted the update-pr-template branch June 26, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants