Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Update for ODH Dashboard v2.8.0 release #734

Conversation

andrewballantyne
Copy link
Member

@andrewballantyne andrewballantyne commented Feb 17, 2023

Dashboard Release Notes:

Dashboard release steps are being tested with this PR. I followed no6 in the release steps. @LaVLaS let me know if we didn't quite get the right steps in place here.

@LaVLaS LaVLaS added this to the ODH 1.5.0 Release milestone Feb 20, 2023
@LaVLaS
Copy link
Contributor

LaVLaS commented Feb 22, 2023

@andrewballantyne There is one item missing that I forgot to add to the odh-dashboard release docs and that is restoring the OWNERS file to the odh-dashboard repo. opendatahub-io/odh-dashboard#972

@LaVLaS
Copy link
Contributor

LaVLaS commented Feb 22, 2023

It looks like the CI test is failing due to a change in the xpath for the jupyter ODHApplication tile

It looks like you need to change the xpath on line 81 of the ods-ci testcase to

//div[contains(@class,"pf-c-card") and @data-id="jupyter"]/div[contains(@class,"pf-c-card__footer")]/a

@andrewballantyne
Copy link
Member Author

@LaVLaS can you help me understand how to read this error the e2e test found? I skimmed looking for it and all I see is "container exited with code 1, reason Error" haha -- clearly an error happened... what error?

@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 1, 2023

@LaVLaS can you help me understand how to read this error the e2e test found? I skimmed looking for it and all I see is "container exited with code 1, reason Error" haha -- clearly an error happened... what error?

After digging into the problem, this might require a bump of the ods-ci release version. I think the failure is due to the fact that we are using 1.20.0 release of their automation and need to update the version

@andrewballantyne andrewballantyne changed the title Update for ODH Dashboard v2.7.0 release Update for ODH Dashboard v2.8.0 release Mar 10, 2023
@andrewballantyne
Copy link
Member Author

Dashboard went through another cycle -- we are not on v2.8.0

@LaVLaS I am thinking the action item here is on you -- if you're thinking it is on me, then we are probably in deadlock 😄 Let me know what you think the next action here is.

@LaVLaS LaVLaS force-pushed the dashboard-2.7.0-release branch from 0966879 to eee1c07 Compare March 15, 2023 02:15
@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 15, 2023

@andrewballantyne These CI tests will be fixed with some changes to

  1. Install the python38 package in the tests/Dockerfile. This would replace python3-pip python3-devel in the package install
  2. We'll need to wait for Use resource variable for ODH Dashboard project name when checking for the ODH Dashboard title red-hat-data-services/ods-ci#720 to be merged tomorrow to fix any errors when checking for Open Data Hub in the odh-dashboard title

@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 27, 2023

@andrewballantyne Following up, this PR #1 to your fork for this PR branch should unblock the CI tests failure in the ods-ci test execution

@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 28, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne andrewballantyne force-pushed the dashboard-2.7.0-release branch from 2f41522 to 6697361 Compare March 28, 2023 15:40
@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 29, 2023

/lgtm

1 similar comment
@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 29, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 29, 2023
@openshift-merge-robot openshift-merge-robot merged commit 498d1cb into opendatahub-io:master Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants