Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove NetworkPolicies created to relax SMCP policies #136

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Jan 10, 2024

Description

Fixes https://issues.redhat.com/browse/RHOAIENG-1015.

How Has This Been Tested?

See https://docs.google.com/document/d/1l5FEtFRc05Nifh6IcKpd3uNH3c5fhwz0gdZtkYZL0B4/edit?usp=sharing for instructions.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@terrytangyuan
Copy link
Member Author

/test all

@danielezonca
Copy link

@bartoszmajsak
FYI

Copy link
Member

@vaibhavjainwiz vaibhavjainwiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove DeleteNetworkPolicy function call from below reference.

if err := r.networkPolicyReconciler.DeleteNetworkPolicy(ctx, isvcNamespace); err != nil {

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@vaibhavjainwiz
Copy link
Member

changes lgtm but it should be merged only after changes of https://issues.redhat.com/browse/RHOAIENG-1014 are merged.

@bartoszmajsak
Copy link
Contributor

For reference, operator PR is also opened opendatahub-io/opendatahub-operator#798

Copy link
Member

@vaibhavjainwiz vaibhavjainwiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@israel-hdez
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, terrytangyuan, vaibhavjainwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1ccf00e into main Jan 17, 2024
5 checks passed
@israel-hdez
Copy link
Contributor

@terrytangyuan You will need to cherry-pick this PR into release-0.11.1.
Once that's done, we will need to sync the branch at: https://github.com/red-hat-data-services/odh-model-controller/tree/rhoai-2.6

@israel-hdez israel-hdez deleted the rm-np branch January 17, 2024 00:13
@zdtsw
Copy link
Member

zdtsw commented Jan 17, 2024

@terrytangyuan You will need to cherry-pick this PR into release-0.11.1. Once that's done, we will need to sync the branch at: red-hat-data-services/odh-model-controller@rhoai-2.6

@terrytangyuan / @israel-hdez can you ensure this is synced to RHOAI to unblock https://issues.redhat.com/browse/RHOAIENG-1904?

@israel-hdez
Copy link
Contributor

@terrytangyuan You will need to cherry-pick this PR into release-0.11.1. Once that's done, we will need to sync the branch at: red-hat-data-services/odh-model-controller@rhoai-2.6

@terrytangyuan / @israel-hdez can you ensure this is synced to RHOAI to unblock https://issues.redhat.com/browse/RHOAIENG-1904?

@zdtsw Looks like it is now there: red-hat-data-services#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants