-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove NetworkPolicies created to relax SMCP policies #136
Conversation
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Skipping CI for Draft Pull Request. |
/test all |
@bartoszmajsak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove DeleteNetworkPolicy
function call from below reference.
odh-model-controller/controllers/reconcilers/kserve_inferenceservice_reconciler.go
Line 166 in 1b3a31c
if err := r.networkPolicyReconciler.DeleteNetworkPolicy(ctx, isvcNamespace); err != nil { |
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
changes lgtm but it should be merged only after changes of https://issues.redhat.com/browse/RHOAIENG-1014 are merged. |
For reference, operator PR is also opened opendatahub-io/opendatahub-operator#798 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, terrytangyuan, vaibhavjainwiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@terrytangyuan You will need to cherry-pick this PR into |
@terrytangyuan / @israel-hdez can you ensure this is synced to RHOAI to unblock https://issues.redhat.com/browse/RHOAIENG-1904? |
@zdtsw Looks like it is now there: red-hat-data-services#24 |
Description
Fixes https://issues.redhat.com/browse/RHOAIENG-1015.
How Has This Been Tested?
See https://docs.google.com/document/d/1l5FEtFRc05Nifh6IcKpd3uNH3c5fhwz0gdZtkYZL0B4/edit?usp=sharing for instructions.
Merge criteria: