[cherry-pick] fix: adds network policies to unblock traffic between components (#145) #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndatahub-io#145) * chore: renames variables to reflect actual objects most of them are called existing/desiredPod even though they are of different type. Most likely copy-pastie mistake * chore: swaps ginkgo to v2 across the tests * fix: adds network policies to unblock traffic between components This solution is based on an initially proposed [script](https://github.com/bartoszmajsak/issue-work-logs/tree/main/RHOAIENG-1003), but with slightly modified namespace selectors. Additional changes: - bumps ginkgo to v2 across the tests - provides composed matcher to easily inspect nested structs - cleans up test setup for KServe - renames variables in reconcilers to reflect actual objects used Fixes https://issues.redhat.com/browse/RHOAIENG-1955 * fix(deps): pins ginkgo to version compatible with go1.19 * chore: moves assertion to Eventually check and aligns timeouts across the calls * chore: fixes wording in godoc * chore: uses KServeNamespace var instead of custom func+struct field * chore: simplifies name generation * Revert "chore: swaps ginkgo to v2 across the tests" This reverts commit d5078aa.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #145 to release branch.