Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for ODH release and update params env to 0.11.1.3 #179

Merged

Conversation

heyselbi
Copy link
Contributor

@heyselbi heyselbi commented Mar 8, 2024

Please note that the target branch is release-0.12.0 although the tag is 0.11.1.3 per @israel-hdez's request. This is so we can match with the rest of the stack semantics for this ODH release.

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: heyselbi <selbi@redhat.com>
Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heyselbi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 8, 2024
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @israel-hdez please confirm:

Please note that the target branch is release-0.12.0 although the tag is 0.11.1.3 per @israel-hdez's request. This is so we can match with the rest of the stack semantics for this ODH release.

@israel-hdez
Copy link
Contributor

LGTM but @israel-hdez please confirm:

Please note that the target branch is release-0.12.0 although the tag is 0.11.1.3 per @israel-hdez's request. This is so we can match with the rest of the stack semantics for this ODH release.

This is more like a @Jooho request than mine. But yes, this is what we want to do.

/lgtm

@heyselbi
Copy link
Contributor Author

heyselbi commented Mar 8, 2024

/hold

@israel-hdez
Copy link
Contributor

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 4187a57 into opendatahub-io:release-0.12.0 Mar 9, 2024
2 checks passed
@heyselbi heyselbi deleted the odh-release0.12 branch March 18, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants